Skip to content

improvement: reduce memory size of workspace#457

Merged
Wodann merged 2 commits intomun-lang:mainfrom
Wodann:improvement/reduce-memory
Oct 31, 2022
Merged

improvement: reduce memory size of workspace#457
Wodann merged 2 commits intomun-lang:mainfrom
Wodann:improvement/reduce-memory

Conversation

@Wodann
Copy link
Copy Markdown
Collaborator

@Wodann Wodann commented Oct 1, 2022

No description provided.

@Wodann Wodann requested a review from baszalmstra October 1, 2022 22:21
@Wodann Wodann self-assigned this Oct 1, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 1, 2022

Codecov Report

Merging #457 (236fe24) into main (3e90eb1) will increase coverage by 3.75%.
The diff coverage is 76.19%.

❗ Current head 236fe24 differs from pull request most recent head db65cd8. Consider uploading reports for the commit db65cd8 to get more accurate results

@@            Coverage Diff             @@
##             main     #457      +/-   ##
==========================================
+ Coverage   79.36%   83.12%   +3.75%     
==========================================
  Files         255      281      +26     
  Lines       13466    16648    +3182     
==========================================
+ Hits        10687    13838    +3151     
- Misses       2779     2810      +31     
Impacted Files Coverage Δ
crates/mun_runtime/src/lib.rs 77.09% <76.19%> (-0.26%) ⬇️
crates/mun_memory/src/type/ffi/primitive.rs 97.67% <0.00%> (-2.33%) ⬇️
crates/tools/src/lib.rs 72.72% <0.00%> (-2.28%) ⬇️
crates/mun_hir/src/fixture.rs 100.00% <0.00%> (ø)
crates/mun_memory/src/cast.rs 100.00% <0.00%> (ø)
crates/mun/tests/integration.rs 100.00% <0.00%> (ø)
crates/mun_abi/src/module_info.rs 100.00% <0.00%> (ø)
crates/mun_runtime_capi/src/gc.rs 100.00% <0.00%> (ø)
crates/mun_abi/src/assembly_info.rs 100.00% <0.00%> (ø)
crates/mun_vfs/src/path_interner.rs 100.00% <0.00%> (ø)
... and 60 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Copy Markdown
Collaborator

@baszalmstra baszalmstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Does this make a big impact?

@Wodann Wodann force-pushed the improvement/reduce-memory branch from 96e1240 to 236fe24 Compare October 2, 2022 12:34
@Wodann Wodann merged commit 3f7b316 into mun-lang:main Oct 31, 2022
@Wodann Wodann deleted the improvement/reduce-memory branch October 31, 2022 16:58
@Wodann Wodann added this to the Mun v0.4.0 milestone Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants