[useMediaQuery][utils] Remove usage of React 18 APIs#29870
Merged
eps1lon merged 4 commits intomui:masterfrom Nov 25, 2021
Merged
[useMediaQuery][utils] Remove usage of React 18 APIs#29870eps1lon merged 4 commits intomui:masterfrom
eps1lon merged 4 commits intomui:masterfrom
Conversation
0f6dc58 to
82b49ec
Compare
|
@material-ui/core: parsed: -0.12% 😍, gzip: -0.14% 😍 |
82b49ec to
26025e3
Compare
Merged
This was referenced Jan 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #29860
These new APIs aren't required for usage with React 18. The either fix some very rare bugs (tearing in
useMediaQuery) or improve existing behavior (useIdon the server).However, in the meantime they disrupt usage with stable React releases which is not ok. Though until React 18 is stable, we need a workaround for webpack/webpack#14814.
A separate
/compatentrypoint likereact-reduxwill require a lot of work from our and consumer side so I don't think this'll be viable.Ideally we'd just put this behind a feature flag instead of reverting but we don't have any infra for that.