[useMediaQuery] Ensure no tearing in React 18#28491
Merged
eps1lon merged 10 commits intomui:masterfrom Nov 17, 2021
Merged
Conversation
|
@material-ui/core: parsed: +0.11% , gzip: +0.12% |
fef0962 to
8bffccf
Compare
8eea96f to
b01158a
Compare
b85accc to
e857d91
Compare
e857d91 to
bea0d3d
Compare
eaf5ea6 to
30afb18
Compare
30afb18 to
891f01a
Compare
c7e0a95 to
fe09647
Compare
This reverts commit 55909aa.
fe09647 to
25e994e
Compare
siriwatknp
approved these changes
Nov 17, 2021
Member
siriwatknp
left a comment
There was a problem hiding this comment.
The code looks good to me 👍. I will need to learn about new APIs in React 18 asap 😂
6 tasks
eps1lon
added a commit
to eps1lon/material-ui
that referenced
this pull request
Nov 24, 2021
This reverts commit e5471f3.
eps1lon
added a commit
to eps1lon/material-ui
that referenced
this pull request
Nov 24, 2021
This reverts commit e5471f3.
eps1lon
added a commit
to eps1lon/material-ui
that referenced
this pull request
Nov 25, 2021
This reverts commit e5471f3.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses
React.useSyncExternalStoreto prevent tearing and cascading updates in React 18.Once
use-sync-external-storeis stable, we should be using that package instead of our shim. I didn't want to use experimental packages if stable versions of React used.