Skip to content

[utils] Use built-in hook when available for useId#26489

Merged
eps1lon merged 10 commits intomui:masterfrom
eps1lon:feat/usePossiblyOpaqueIdentifier
Nov 23, 2021
Merged

[utils] Use built-in hook when available for useId#26489
eps1lon merged 10 commits intomui:masterfrom
eps1lon:feat/usePossiblyOpaqueIdentifier

Conversation

@eps1lon
Copy link
Member

@eps1lon eps1lon commented May 28, 2021 •
edited
Loading

Avoids cascading updates when React.useId is available.

Uses React.useId if available, otherwise falls back to our useId.

React 18 pipeline: https://app.circleci.com/pipelines/github/mui-org/material-ui/54514/workflows/d4000f0c-a493-456d-8d76-f3fa759de609
React 18 docs: https://618245b96091680007591478--material-ui.netlify.app/components/autocomplete/#ComboBox

@eps1lon eps1lon added type: new feature Expand the scope of the product to solve a new problem. package: utils Specific to the utils package. labels May 28, 2021
@mui-pr-bot
Copy link

mui-pr-bot commented May 28, 2021 •
edited
Loading

Details of bundle changes

Generated by 🚫 dangerJS against 281d24d

@eps1lon eps1lon mentioned this pull request May 28, 2021
Merged
@eps1lon

This comment has been minimized.

Sign in to view
@eps1lon eps1lon force-pushed the feat/usePossiblyOpaqueIdentifier branch from 39dce5b to 161887f Compare May 31, 2021 09:13
@eps1lon

This comment has been minimized.

Sign in to view
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Jun 3, 2021
@eps1lon eps1lon force-pushed the feat/usePossiblyOpaqueIdentifier branch from f121744 to db747cc Compare June 10, 2021 08:16
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Jun 10, 2021
@eps1lon eps1lon force-pushed the feat/usePossiblyOpaqueIdentifier branch from 4152790 to 4f7868f Compare June 10, 2021 14:20
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Jun 18, 2021
@oliviertassinari oliviertassinari deleted the branch mui:master June 22, 2021 00:28
@oliviertassinari oliviertassinari changed the base branch from foo to next June 22, 2021 00:48
@eps1lon eps1lon added this to the v5.1 milestone Aug 25, 2021
eps1lon
eps1lon commented Aug 25, 2021
View reviewed changes
@eps1lon eps1lon changed the base branch from next to master September 14, 2021 09:29
@eps1lon

This comment has been minimized.

Sign in to view
@eps1lon eps1lon changed the title [utils] Add usePossiblyOpaqueIdentifier [utils] Add useReactId Oct 27, 2021
@eps1lon eps1lon force-pushed the feat/usePossiblyOpaqueIdentifier branch from 4f7868f to 83369fa Compare October 27, 2021 08:28
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Oct 27, 2021
@eps1lon eps1lon force-pushed the feat/usePossiblyOpaqueIdentifier branch from 83369fa to 19d15ca Compare October 27, 2021 10:28
@NMinhNguyen

This comment has been minimized.

Sign in to view
@eps1lon

This comment has been minimized.

Sign in to view
NMinhNguyen
NMinhNguyen reviewed Oct 28, 2021
View reviewed changes
@eps1lon eps1lon force-pushed the feat/usePossiblyOpaqueIdentifier branch 2 times, most recently from 084db49 to b0d76c7 Compare October 28, 2021 18:15
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Oct 31, 2021
@eps1lon eps1lon force-pushed the feat/usePossiblyOpaqueIdentifier branch from 790fec9 to fab3012 Compare November 4, 2021 10:20
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Nov 4, 2021
@oliviertassinari oliviertassinari removed this from the v5.1 milestone Nov 10, 2021
@eps1lon eps1lon mentioned this pull request Nov 15, 2021
Merged
1 task
@eps1lon eps1lon force-pushed the feat/usePossiblyOpaqueIdentifier branch from fab3012 to 1a0e802 Compare November 19, 2021 11:33
@eps1lon eps1lon added this to the React 18 milestone Nov 21, 2021
@eps1lon eps1lon removed the on hold There is a blocker, we need to wait. label Nov 21, 2021
@eps1lon eps1lon requested a review from a team November 21, 2021 21:45
mnajdova
mnajdova approved these changes Nov 22, 2021
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

eps1lon
eps1lon commented Nov 22, 2021
View reviewed changes
eps1lon
eps1lon commented Nov 22, 2021
View reviewed changes
@eps1lon eps1lon merged commit 3323b23 into mui:master Nov 23, 2021
@eps1lon eps1lon deleted the feat/usePossiblyOpaqueIdentifier branch November 23, 2021 08:07
@eps1lon eps1lon mentioned this pull request Nov 23, 2021
Open
6 tasks
eps1lon added a commit to eps1lon/material-ui that referenced this pull request Nov 24, 2021
@eps1lon
Revert "[utils] Use built-in hook when available for useId (mui#26489)"
2e947f8 
This reverts commit 3323b23.
eps1lon added a commit to eps1lon/material-ui that referenced this pull request Nov 24, 2021
@eps1lon
Revert "[utils] Use built-in hook when available for useId (mui#26489)"
802b8d3 
This reverts commit 3323b23.
eps1lon added a commit to eps1lon/material-ui that referenced this pull request Nov 25, 2021
@eps1lon
Revert "[utils] Use built-in hook when available for useId (mui#26489)"
e8db247 
This reverts commit 3323b23.
This was referenced Jan 16, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mnajdova mnajdova mnajdova approved these changes

@siriwatknp siriwatknp siriwatknp approved these changes

+1 more reviewer

@NMinhNguyen NMinhNguyen NMinhNguyen left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

package: utils Specific to the utils package. type: new feature Expand the scope of the product to solve a new problem.

Projects

None yet

Milestone

Leverage React 18

Development

Successfully merging this pull request may close these issues.

6 participants

@eps1lon @mui-pr-bot @NMinhNguyen @mnajdova @siriwatknp @oliviertassinari