[Card] Migrate CardMedia to emotion#24625
Merged
Conversation
|
@material-ui/core: parsed: +0.14% , gzip: +0.08% |
mnajdova
reviewed
Jan 26, 2021
mnajdova
reviewed
Jan 26, 2021
mnajdova
reviewed
Jan 26, 2021
Member
mnajdova
left a comment
There was a problem hiding this comment.
Looks much better! Last two comments and I believe we are good to go :)
mnajdova
approved these changes
Jan 26, 2021
natac13
commented
Jan 26, 2021
|
|
||
| it('warns when neither `children`, nor `image`, nor `src`, nor `component` are provided', () => { | ||
| expect(() => { | ||
| PropTypes.checkPropTypes(CardMedia.Naked.propTypes, { classes: {} }, 'prop', 'MockedName'); |
Contributor
Author
There was a problem hiding this comment.
This test was failing with propTypes cannot be read from undefined.
I looked at other Mui component with this test but none of the others have been converted yet, therefore I was not sure if this was the correct approach.
Removing the Naked got the tests passing.
Member
There was a problem hiding this comment.
A bit of clarification Naked was added by the withStyles utility, we don't use it anymore, so this is correct :)
xs9627
added a commit
to xs9627/material-ui
that referenced
this pull request
Jan 27, 2021
* next: (34 commits) [Tab] Migrate to emotion (mui#24651) [TextField] Migrate Input component to emotion (mui#24638) [ImageList] Migrate ImageListItemBar to emotion (mui#24632) [CircularProgress] Migrate to emotion (mui#24622) [DataTable] Add example in docs for data table (mui#24428) [Card] Migrate CardActionArea to emotion (mui#24636) [core] Fix `next` using stale pages (mui#24635) [List] Migrate ListItemIcon to emotion (mui#24630) [ClickAwayListener] Fix `children` and `onClickAway` types (mui#24565) [docs] Include in docs directive to silence `eslint` erroneous warning (mui#24644) [Fab] Migrate to emotion (mui#24618) [TextField] Migrate FilledInput to emotion (mui#24634) [Card] Migrate CardHeader to emotion (mui#24626) [Card] Migrate CardMedia to emotion (mui#24625) [ImageList] Migrate ImageListItem to emotion (mui#24619) [website] Add vision block (mui#24603) [docs] Add sorting section (mui#24637) [TextField] Prepare removal of labelWidth prop (mui#24595) [Dialog] Migrate DialogTitle to emotion (mui#24623) [ImageList] Migrate to emotion (mui#24615) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#24405