Skip to content

[DataTable] Add example in docs for data table#24428

Merged
DanailH merged 8 commits intomui:nextfrom
DanailH:feature/DataTable-add-example-in-docs
Jan 27, 2021
Merged

[DataTable] Add example in docs for data table#24428
DanailH merged 8 commits intomui:nextfrom
DanailH:feature/DataTable-add-example-in-docs

Conversation

@DanailH
Copy link
Member

@DanailH DanailH commented Jan 15, 2021

https://deploy-preview-24428--material-ui.netlify.app/components/tables/#data-table

For now, this will remain as a draft. Once the new version of DataGrid that supports v5 is released I'll convert it to a normal PR and we can merge it.

This is part of mui/mui-x#441 and mui/mui-x#855.

@DanailH DanailH added the docs Improvements or additions to the documentation. label Jan 15, 2021
@DanailH DanailH self-assigned this Jan 15, 2021
@mui-pr-bot
Copy link

mui-pr-bot commented Jan 15, 2021

Details of bundle changes

Generated by 🚫 dangerJS against 6d96c4f

DanailH and others added 2 commits January 15, 2021 14:59
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
@oliviertassinari
Copy link
Member

oliviertassinari commented Jan 15, 2021

The documentation isn't working in dev mode, a tip, look into:
https://github.com/mui-org/material-ui/blob/b071899deabdaebd4ccf4f7948a24d1ed33a1411/docs/next.config.js#L110

@oliviertassinari oliviertassinari added the scope: data grid Changes related to the data grid. label Jan 15, 2021
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to work well https://deploy-preview-24428--material-ui.netlify.app/components/tables/#data-table. I think that we can merge once the pull request for v5 support on Material-UI X is merged and released.

@oliviertassinari oliviertassinari added the on hold There is a blocker, we need to wait. label Jan 20, 2021
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Jan 26, 2021
@oliviertassinari
Copy link
Member

@DanailH This effort can be resumed now.

@DanailH DanailH marked this pull request as ready for review January 27, 2021 07:55
@DanailH
Copy link
Member Author

DanailH commented Jan 27, 2021

@material-ui/data-grid@4.0.0-alpha.18 was released yesterday. I'm marking this draft as ready for review.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Jan 27, 2021
@DanailH DanailH removed the on hold There is a blocker, we need to wait. label Jan 27, 2021
@DanailH DanailH merged commit 0645524 into mui:next Jan 27, 2021
xs9627 added a commit to xs9627/material-ui that referenced this pull request Jan 27, 2021
* next: (34 commits)
  [Tab] Migrate to emotion (mui#24651)
  [TextField] Migrate Input component to emotion (mui#24638)
  [ImageList] Migrate ImageListItemBar to emotion (mui#24632)
  [CircularProgress] Migrate to emotion (mui#24622)
  [DataTable] Add example in docs for data table (mui#24428)
  [Card] Migrate CardActionArea to emotion (mui#24636)
  [core] Fix `next` using stale pages (mui#24635)
  [List] Migrate ListItemIcon to emotion (mui#24630)
  [ClickAwayListener] Fix `children` and `onClickAway` types (mui#24565)
  [docs] Include in docs directive to silence `eslint` erroneous warning (mui#24644)
  [Fab] Migrate to emotion (mui#24618)
  [TextField] Migrate FilledInput to emotion (mui#24634)
  [Card] Migrate CardHeader to emotion (mui#24626)
  [Card] Migrate CardMedia to emotion (mui#24625)
  [ImageList] Migrate ImageListItem to emotion (mui#24619)
  [website] Add vision block (mui#24603)
  [docs] Add sorting section (mui#24637)
  [TextField] Prepare removal of labelWidth prop (mui#24595)
  [Dialog] Migrate DialogTitle to emotion (mui#24623)
  [ImageList] Migrate to emotion (mui#24615)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to the documentation. scope: data grid Changes related to the data grid.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants