Travis build failed because of a network issue or something apparently. npm run build works fine.

@louy maybe try pushing an empty commit to re-start the Travis build?

@shaurya947 I believe admins can restart a build manually.
http://stackoverflow.com/a/17624403/1644422

It would be much cleaner than an empty commit.

@shaurya947 can I get any feedback on this?

@oliviertassinari do you think adding another function to StylePropable that flips the direction automatically for all components might be a better approach?

Well, If you want to add the support of RTL on a large set of component, yes I would use a different approach.
I see two issues, first, we are going to duplicate this in a lot of different component. Second, in terms of perf/memory, I think that we can do better.
My idea would be to precompute on object called RTL at the theme level depending on the isRTL boolean.

Sorry @louy, I've been a little MIA on this issue.

I don't think using the mixin is the best option. But I agree with @oliviertassinari that having something on the theme-level is a good approach. Take a look at theme-manager and see if you have any ideas :-)

For instance, when we contruct the theme we can compute a LTR variable that we add to the theme.

if (isRtl) {
  LTR = {
    right: 'left',
    left: 'right',
    marginRight: 'marginLeft',
    paddingLeft: 'paddingRight',
  }
} else {
  LTR = {
    right: 'right',
    left: 'left',
    marginRight: 'marginRight',
    paddingLeft: 'paddingLeft',
  }
}

👍

Hi,
I've made direction flipping automated using the function "prepareStyles" in style-propable. Please try to get back on this and merge it before making edits because it wasn't easy to do and took a lot of effort to refactor some stuff.

To see it in action, just uncomment the line in docs/src/components/master.jsx.

A few things to be careful about:

• Never call prepareStyles on the same "style" object twice. You'll get a warning if you do so.
• I wasn't able to reverse CircularProgress and LoadingIndicator yet.
• Not all css properties are supported yet. We have padding, margin, border, transform, float, direction, right/left. Those are the ones I found that are being used in the project currently.
• I should probably add unit tests for utils/styles. I just wanted to finish this asap to avoid rebasing.
• I thought you might have some performance considerations. So when isRtl isn't set to true the ensureDirection function does nothing. This means performance won't be affected.

WOW, I love it 👍 👍 ❤️ ❤️

I also wasn't able to add rtl support to all docs pages because they're written in es6 class style and I need to use mixins. That shouldn’t be a big issue.
The CodeMirror component has a tiny issue with spacing as well. It's not a full react component and I didn't get the chance to fix it yet. :)

I like this approach. I'm wondering if this can work with flexbox.
Aside from that. I think that it would be better to squash all the commits into one or two (for history readability).

Awesome! It's working fine with <Grid> so I guess we won't be having issues.
There might be some possible cleanups (like changing mergeAndPrefix to just mergeStyles). I'll write some documentation about this whole thing this week and send another PR.
I'll squash them all in a minute.

@shaurya947 can we get this merged soon?

@louy see the comments above and let me know what you think.

Also, there's a lot of changes here. Can you make sure that nothing breaks when isRtl is set to false (the default value I suppose)?

Good job consolidating all this btw 👍

Hi @shaurya947,

Just did some cleanup and the a quick look through the whole docs to make nothing is broken. Everything looks fine.
I've removed styleConstants from ThemeManager as well.

Thanks :)

I'll go ahead and merge this then, and we can tackle any issues that come along the way. Thanks @louy

@andreychev Can you submit a PR to fix this ?