Skip to content

Merge react-0.14-support branch#1882

Closed
oliviertassinari wants to merge 25 commits intomui:masterfrom
oliviertassinari:merge-react-v14
Closed

Merge react-0.14-support branch#1882
oliviertassinari wants to merge 25 commits intomui:masterfrom
oliviertassinari:merge-react-v14

Conversation

@oliviertassinari
Copy link
Member

Merge react-0.14-support branch inside master.
Also fix this.findDOMNode().

Aaike and others added 23 commits September 28, 2015 21:10
Only application (that wont be used as npm modules) should declare peerDependencies as real dependencies to bring them to the build.

NPM 3 do not install peerDependencies anymore.
# Conflicts:
#	docs/src/app/components/pages/components/tabs.jsx
#	src/enhanced-textarea.jsx
#	src/slider.jsx
#	src/styles/theme-manager.js
React 0.14 support - merge master
Temporarily included personal fork until pull-request is accepted upstream.
- Replaced unix command with rimraf for cross-platform support
- Updated dependencies to resolve warnings
- Updated to temporary fork of react-draggable2 with 0.14 support.
Contains React 0.14 compatibility fixes.
# Conflicts:
#	docs/src/app/app-routes.jsx
#	docs/src/app/components/pages/components.jsx
#	package.json
[React-v14] Use findDOMNode where needed and fix package
@oliviertassinari oliviertassinari changed the title Merge react v14 Merge react-0.14-support branch Oct 14, 2015
@louy
Copy link
Contributor

louy commented Oct 14, 2015

RTL is not broken btw.
src/mixins/style-propable.js#L35
You were checking the wrong function

@oliviertassinari
Copy link
Member Author

@louy Oh, I will have a closer look then.
I was missing:

  contextTypes: {
    muiTheme: React.PropTypes.object,
  },

@shaurya947
Copy link
Contributor

@oliviertassinari this was still missing some commits from master I believe. I have rebased react-0.14-support with master. I will apply your commit to fix this.findDOMNode(), and then merge into master.

@oliviertassinari
Copy link
Member Author

this was still missing some commits from master

Well, If you say so, I didn't know that a merge can lost commit. That's weird.

Ok, thanks!

@shaurya947
Copy link
Contributor

d9uufb2yzq

@oliviertassinari oliviertassinari deleted the merge-react-v14 branch October 14, 2015 19:53
@borm
Copy link

borm commented Oct 14, 2015

npm WARN peerDependencies The peer dependency react@~0.13 included from material-ui
update npm package

mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Nov 10, 2020
* [docs] Update responsiveness section

close mui#1882

* Update index.mdx

* Update index.mdx

* Update docs/pages/demo/datepicker/index.mdx

* apply same description to the other components

Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Co-authored-by: Dmitriy Kovalenko <dmtr.kovalenko@outlook.com>
@zannager zannager added the docs Improvements or additions to the documentation. label Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to the documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants