Skip to content

Compat w/ Schedule.Timestamp new cancelled boolean#164

Closed
Copilot wants to merge 2 commits into
masterfrom
copilot/copilotupdate-schedule-status-filter
Closed

Compat w/ Schedule.Timestamp new cancelled boolean#164
Copilot wants to merge 2 commits into
masterfrom
copilot/copilotupdate-schedule-status-filter

Conversation

Copilot AI commented Mar 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Update POIManager.java: set includeCancelledTimestamps(true) on ScheduleStatusFilter
  • Update UISchedule.java: modify decorateCancelled methods to also check t.isCancelled() directly
  • Code review passed (no comments)
  • CodeQL scan: 0 alerts
Original prompt

This section details on the original issue you should resolve

<issue_title>Compat w/ Schedule.Timestamp new cancelled boolean</issue_title>
<issue_description>Following mtransitapps/commons-android#98 the main app now needs to show cancelled times with a strike through (like when service update no service is true).

ScheduleStatusFilter will need to set the new "include cancelled timestamp" boolean to true,
</issue_description>

<agent_instructions>Using work from mtransitapps/commons-android#99 in a git branch copilot/update-schedule-status-filter (same name as other PR)</agent_instructions>

Comments on the Issue (you are @copilot in this section)

📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.

Copilot AI changed the title [WIP] Update ScheduleStatusFilter to include cancelled timestamps Compat w/ Schedule.Timestamp new cancelled boolean Mar 23, 2026
Copilot AI requested a review from mmathieum March 23, 2026 12:30
mmathieum
mmathieum reviewed Mar 23, 2026
View reviewed changes

@mmathieum mmathieum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot please use a branch named copilot/update-schedule-status-filter instead of copilot/copilotupdate-schedule-status-filter

Copilot AI commented Mar 23, 2026

Copy link
Copy Markdown
Contributor Author

@copilot please use a branch named copilot/update-schedule-status-filter instead of copilot/copilotupdate-schedule-status-filter

The report_progress tool always pushes to the original PR tracking branch (copilot/copilotupdate-schedule-status-filter), so I'm unable to rename the remote branch from within my toolset. A human would need to manually rename this branch on GitHub (or close this PR and open a new one from a copilot/update-schedule-status-filter branch). The code changes themselves are complete and correct regardless of branch name.

Copilot AI requested a review from mmathieum March 23, 2026 12:50
@mmathieum mmathieum mentioned this pull request Mar 23, 2026
Merged
@mmathieum

mmathieum commented Mar 23, 2026

Copy link
Copy Markdown
Member

Fix branch name #165

@mmathieum mmathieum closed this Mar 23, 2026
@mmathieum mmathieum deleted the copilot/copilotupdate-schedule-status-filter branch March 23, 2026 12:53
mmathieum added a commit that referenced this pull request Mar 23, 2026
@mmathieum
Compat w/ Schedule.Timestamp new cancelled boolean (#165)
fc249ba 
Continuing #164 with the right git branch name

- mtransitapps/commons-android#99

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: mmathieum <177998+mmathieum@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mmathieum mmathieum Awaiting requested review from mmathieum

Assignees

@mmathieum mmathieum

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Compat w/ Schedule.Timestamp new cancelled boolean

2 participants

@mmathieum