Skip to content

Compat w/ Schedule.Timestamp new cancelled boolean#165

Merged
mmathieum merged 4 commits into
masterfrom
copilot/update-schedule-status-filter
Mar 23, 2026
Merged

Compat w/ Schedule.Timestamp new cancelled boolean#165
mmathieum merged 4 commits into
masterfrom
copilot/update-schedule-status-filter

Conversation

@mmathieum

@mmathieum mmathieum commented Mar 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

@gemini-code-assist

gemini-code-assist Bot commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the application's compatibility with a new cancelled boolean in Schedule.Timestamp by ensuring that cancelled schedule entries are properly retrieved and visually distinguished in the user interface. The changes allow the system to fetch and display cancelled timestamps, providing a more accurate and informative schedule view for users.

Highlights

  • Schedule Data Filtering: Enabled the ScheduleStatusFilter to include cancelled timestamps when requesting schedule data, ensuring that all relevant schedule entries are fetched.
  • UI Decoration for Cancelled Timestamps: Updated the decorateCancelled methods in UISchedule to directly apply a cancelled style to timestamps if their isCancelled() flag is true, improving visual clarity for users.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@mmathieum mmathieum mentioned this pull request Mar 23, 2026
Closed
4 tasks
@mmathieum mmathieum self-assigned this Mar 23, 2026
@github-actions

github-actions Bot commented Mar 23, 2026 •
edited
Loading

Copy link
Copy Markdown

Qodana for JVM

It seems all right 👌

No new problems were found according to the checks applied

☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Mar 23, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request successfully integrates the new cancelled boolean from Schedule.Timestamp into the application. The ScheduleStatusFilter is updated to include cancelled timestamps, and the decorateCancelled methods in UISchedule now correctly apply a strikethrough style to visually represent cancelled schedules. The changes are concise, well-placed, and directly address the stated objective of compatibility with the new timestamp property.

@mmathieum mmathieum marked this pull request as ready for review March 23, 2026 12:58
@mmathieum mmathieum linked an issue Mar 23, 2026 that may be closed by this pull request
Compat w/ Schedule.Timestamp new cancelled boolean #163
Closed
@mmathieum mmathieum merged commit fc249ba into master Mar 23, 2026
7 checks passed
@mmathieum mmathieum deleted the copilot/update-schedule-status-filter branch March 23, 2026 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@mmathieum mmathieum

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Compat w/ Schedule.Timestamp new cancelled boolean

2 participants

@mmathieum