Add hypothesis-based formatting tests and workaround #858#859
Merged
skirpichev merged 4 commits intompmath:masterfrom Sep 6, 2024
Merged
Add hypothesis-based formatting tests and workaround #858#859skirpichev merged 4 commits intompmath:masterfrom
skirpichev merged 4 commits intompmath:masterfrom
Conversation
4d2ec91 to
3ad168a
Compare
3ad168a to
2a3f8b3
Compare
Closed
Contributor
|
This is better but still fails in some cases, for example, >>> format(mp.mpf('0.99'), '.1f')
'1.'
>>> format(mp.mpf('0.999'), '.2f')
'1.0'The reason is that >>> to_digits_exp(mp.mpf(0.99)._mpf_, 15)
('', '989999999999999991', -1)
>>> to_digits_exp(mp.mpf(0.999)._mpf_, 15)
('', '998999999999999999', -1)The solution is to improve the hack to take into account the cases where the last rounded digit is not a 9, but one of the digits that would be rounded up. |
Collaborator
Author
Thanks, I've cherry-picked some commits from that pr and did some cleanup for the fix. |
This comment was marked as outdated.
This comment was marked as outdated.
Fix also few other minor issues, coming from tests. Closes mpmath#858 Co-authored-by: Javier Garcia <javier.garcia.tw@hotmail.com>
Should be useful for formatting complex numbers
929b972 to
15df470
Compare
Collaborator
Author
Collaborator
Author
|
@javierelpianista, are you ok with this or prefer #860? |
Contributor
I'm OK with this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.