Closed
Conversation
Fix also few other minor issues, coming from tests. Closes mpmath#858
Should be useful for formatting complex numbers
* Move the 'hack' to round_digits * Improve code to better detect when to add an extra decimal 0 to acommodate for the required precision
skirpichev
reviewed
Sep 2, 2024
| return sign, digits, exponent | ||
|
|
||
| def round_digits(sign, digits, dps, base, rounding=round_nearest): | ||
| def round_digits(sign, digits, dps, base, rounding=round_nearest, fixed=False): |
Collaborator
There was a problem hiding this comment.
It seems to be the key. Now I think that the fix should go to "Rounding up kills some instances" block and could be one-liner.
Collaborator
|
#859 merged with fix from this pr. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves upon the fixes in #859 for fixed formatting of numbers like 0.99, 0.999, etc.