refactor: Make the wrapAPIs function take the chrome object as a parameter#139
Merged
rpl merged 1 commit intomozilla:masterfrom Aug 27, 2018
Merged
refactor: Make the wrapAPIs function take the chrome object as a parameter#139rpl merged 1 commit intomozilla:masterfrom
wrapAPIs function take the chrome object as a parameter#139rpl merged 1 commit intomozilla:masterfrom
Conversation
wrapAPIs function take the chrome object as a parameterwrapAPIs function take the chrome object as a parameter
wrapAPIs function take the chrome object as a parameterwrapAPIs function take the chrome object as a parameter
wrapAPIs function take the chrome object as a parameterwrapAPIs function take the chrome object as a parameter
2904472 to
7d7f110
Compare
Closed
c0730d4 to
39ac89c
Compare
wrapAPIs function take the chrome object as a parameterwrapAPIs function take the chrome object as a parameter
wrapAPIs function take the chrome object as a parameterwrapAPIs function take the chrome object as a parameter
wrapAPIs function take the chrome object as a parameterwrapAPIs function take the chrome object as a parameter
39ac89c to
49d20df
Compare
rpl
approved these changes
Aug 16, 2018
Rob--W
approved these changes
Aug 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #114 (review), #114 (comment) and #114 (comment).
This is a breaking change, which will cause #114 and
#140to require rebasing.review?(@rpl)