fix: sendMessage promise should resolve to undefined when no listeners reply#140
Merged
rpl merged 1 commit intomozilla:masterfrom Jul 4, 2018
Merged
Conversation
lydell
reviewed
Jul 2, 2018
|
|
||
| test("sendMessage and no listener answers", async (t) => { | ||
| const reply = await browser.runtime.sendMessage("test - sendMessage and no listener answers"); | ||
| t.equal(reply, undefined, "Got undefined as a reply a expected"); |
Rob--W
reviewed
Jul 2, 2018
test/test-runtime-onMessage.js
Outdated
| }, | ||
| }; | ||
|
|
||
| fakeChrome.runtime.sendMessage.onFirstCall().callsArgWith(1, ["res1", "res2"]); |
Member
There was a problem hiding this comment.
Nit: Use .callsArg(1) or callsArgWith(1, [undefined]); .
In reality the sendMessage callback won't ever be invoked with two arguments.
Closed
5229506 to
8d5ab25
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the changes from #131 with the addition of some small tweaks (from the last review on #131) and an additional integration test (to check that the behavior of the polyfill in Chrome is the same of the one on Firefox with the native promised APIs).
Fixes #130