Skip to content

fix: bring "cargo build -Zprofile" support back#2306

Merged
sylvestre merged 6 commits intomainfrom
bring-z-profile-back
Jan 2, 2025
Merged

fix: bring "cargo build -Zprofile" support back#2306
sylvestre merged 6 commits intomainfrom
bring-z-profile-back

Conversation

@Xuanwo
Copy link
Copy Markdown
Collaborator

@Xuanwo Xuanwo commented Dec 30, 2024

Close #2297.

In #2282, I mistakenly removed the -Zprofile support, which is still used by many older Rust nightly toolchains. This PR restores this feature.

Additionally, this PR updates the CI to ensure it will not be broken by similar changes in the future.

Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Copy Markdown
Collaborator Author

Xuanwo commented Dec 30, 2024

cc @sylvestre and @glandium for a review, thanks!

Signed-off-by: Xuanwo <github@xuanwo.io>
@sylvestre sylvestre requested a review from glandium December 30, 2024 08:44
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Copy Markdown
Collaborator Author

Xuanwo commented Dec 30, 2024

-Zprofile works now:

image

@sylvestre sylvestre merged commit 989e7e3 into main Jan 2, 2025
@sylvestre sylvestre deleted the bring-z-profile-back branch January 2, 2025 17:58
tottoto pushed a commit to tottoto/sccache that referenced this pull request Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants