Skip to content

Revert "feat: Use profile-generate to replace outdated -Zprofile options"#2297

Closed
sylvestre wants to merge 1 commit intomainfrom
revert-2282-fix-ci
Closed

Revert "feat: Use profile-generate to replace outdated -Zprofile options"#2297
sylvestre wants to merge 1 commit intomainfrom
revert-2282-fix-ci

Conversation

@sylvestre
Copy link
Copy Markdown
Collaborator

Reverts #2282

@Xuanwo
Copy link
Copy Markdown
Collaborator

Xuanwo commented Dec 19, 2024

Hi, reverting this will break all stable Rust. I believe it's better to provide forward compatibility instead, allowing sccache to also accept -Z simultaneously.

@sylvestre
Copy link
Copy Markdown
Collaborator Author

@Xuanwo sorry for the lack of context. It caused some significant regressions in term of build for firefox:
https://bugzilla.mozilla.org/show_bug.cgi?id=1937804

@Xuanwo
Copy link
Copy Markdown
Collaborator

Xuanwo commented Dec 19, 2024

@Xuanwo sorry for the lack of context. It caused some significant regressions in term of build for firefox: bugzilla.mozilla.org/show_bug.cgi?id=1937804

Got it. Let me find sometime tomorrow to see how can we fix this.

@glandium
Copy link
Copy Markdown
Collaborator

See my comment in #2282. Considering the support for --profile-generate is wrong, fixing the whole thing is going to amount to essentially revert this and reintroduce --profile-generate in a simpler form. All in all, it's going to be simpler to start from the reverted state.

@sylvestre
Copy link
Copy Markdown
Collaborator Author

@Xuanwo have you been able to have a look?
Thanks :)

@Xuanwo
Copy link
Copy Markdown
Collaborator

Xuanwo commented Dec 30, 2024

@Xuanwo have you been able to have a look? Thanks :)

Should be fixed by #2306

tottoto added a commit to tottoto/sccache that referenced this pull request Feb 6, 2026
* fix outdated limit in comment

This mention was missed when the default changed in mozilla#1335

* Add backquotes

Co-authored-by: tottoto <tottotodev@gmail.com>

---------

Co-authored-by: tottoto <tottotodev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants