Revert "feat: Use profile-generate to replace outdated -Zprofile options"#2297
Revert "feat: Use profile-generate to replace outdated -Zprofile options"#2297
Conversation
|
Hi, reverting this will break all stable Rust. I believe it's better to provide forward compatibility instead, allowing sccache to also accept |
|
@Xuanwo sorry for the lack of context. It caused some significant regressions in term of build for firefox: |
Got it. Let me find sometime tomorrow to see how can we fix this. |
|
See my comment in #2282. Considering the support for --profile-generate is wrong, fixing the whole thing is going to amount to essentially revert this and reintroduce --profile-generate in a simpler form. All in all, it's going to be simpler to start from the reverted state. |
|
@Xuanwo have you been able to have a look? |
* fix outdated limit in comment This mention was missed when the default changed in mozilla#1335 * Add backquotes Co-authored-by: tottoto <tottotodev@gmail.com> --------- Co-authored-by: tottoto <tottotodev@gmail.com>
Reverts #2282