Port controller_manager submodule of moveit_core to ROS 2#6
Merged
davetcoleman merged 2 commits intomoveit:masterfrom Feb 25, 2019
Merged
Conversation
mlautman
previously approved these changes
Feb 19, 2019
Contributor
mlautman
left a comment
There was a problem hiding this comment.
It looks like the controller manager will still need a replacement for ros::Duration in the waitForExecution method but I assume you will take care of that later on
Contributor
Author
that's right, I believe @anasarrak was looking at this aspect this morning. We'll send a PR once it's ready I guess. |
| * | ||
| * The controller is expected to execute the trajectory, but this function call should not block. | ||
| * Blocking is achievable by calling waitForExecution(). | ||
| * Return false when the controller cannot accept the trajectory. */ |
davetcoleman
approved these changes
Feb 25, 2019
AndyZe
referenced
this pull request
in AndyZe/moveit2
Aug 14, 2021
* set robot state positions/velocities/accelerations from ruckig outout * updated file name for ruckig traj smoothing * added plugin for ruckig trajectory smoothing * removed extra space * added ruckig to file name and update authors * deleted unnesessary lines Co-authored-by: Wyatt Rees <wyatt.rees@gmail.com>
AndyZe
referenced
this pull request
in AndyZe/moveit2
Aug 21, 2021
* set robot state positions/velocities/accelerations from ruckig outout * updated file name for ruckig traj smoothing * added plugin for ruckig trajectory smoothing * removed extra space * added ruckig to file name and update authors * deleted unnesessary lines Co-authored-by: Wyatt Rees <wyatt.rees@gmail.com>
AndyZe
referenced
this pull request
in AndyZe/moveit2
Sep 15, 2021
* set robot state positions/velocities/accelerations from ruckig outout * updated file name for ruckig traj smoothing * added plugin for ruckig trajectory smoothing * removed extra space * added ruckig to file name and update authors * deleted unnesessary lines Co-authored-by: Wyatt Rees <wyatt.rees@gmail.com>
AndyZe
pushed a commit
that referenced
this pull request
Dec 8, 2021
* Install hybrid_planning_demo_node separately to avoid exporting it * Fix exported include directory * Remove getTargetWayPointIndex() from abstract trajectory operator class * Delete unused getTargetWayPointIndex()
galou
pushed a commit
to galou/moveit2
that referenced
this pull request
Sep 7, 2022
Fix kdl joint weights and update our branch from main
Closed
This was referenced Jul 3, 2023
This was referenced Jan 18, 2024
6 tasks
This was referenced Jan 12, 2025
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.