CMake fix and cleanup abstract class#6
CMake fix and cleanup abstract class#6AndyZe merged 4 commits intoAndyZe:feature/hybrid_planningfrom
Conversation
|
Yes, let's remove getTargetWayPointIndex() since it isn't used. 👍 Will push a commit for that |
|
Running the demo today, I get an error about the OMPL planning pipeline not loading. Sigh. I wonder if it's something to do with my workspace. (It's not just your branch, my branch has the same error.) I'm on the latest commit of moveit_resources, |
a154265 to
e8c5d1b
Compare
How are you supposed to get the target waypoint from the local solver if the TrajectoryOperator doesn't have a function to provide it? I thought the whole idea about this class is that it defines the logic what the next waypoint is based on the current state. But maybe there is another way to do the same thing. |
Yes, it is done within the operator and the local solver receives a local trajectory through a call of The local trajectory for the solver could contain more than a single waypoint. This is why I think this function is only useful in local sampler which only forwards a single waypoint of the global trajectory. But it was not used. |
|
getTargetWayPointIndex() is something I added just recently for detecting if the local planner was stuck for X iterations. But, I think I implemented it in the wrong place. |
6411258 to
ca2867c
Compare
25a56ec to
8af33eb
Compare
* Install hybrid_planning_demo_node separately to avoid exporting it * Fix exported include directory * Remove getTargetWayPointIndex() from abstract trajectory operator class * Delete unused getTargetWayPointIndex() Co-authored-by: AndyZe <zelenak@picknik.ai>
* Install hybrid_planning_demo_node separately to avoid exporting it * Fix exported include directory * Remove getTargetWayPointIndex() from abstract trajectory operator class * Delete unused getTargetWayPointIndex() Co-authored-by: AndyZe <zelenak@picknik.ai>
* Install hybrid_planning_demo_node separately to avoid exporting it * Fix exported include directory * Remove getTargetWayPointIndex() from abstract trajectory operator class * Delete unused getTargetWayPointIndex()
* Install hybrid_planning_demo_node separately to avoid exporting it * Fix exported include directory * Remove getTargetWayPointIndex() from abstract trajectory operator class * Delete unused getTargetWayPointIndex()
Description
When I tried to add hybrid planning as a dependency in a different package I got several CMake errors/warnings like this:
I fixed them by installing the hybrid_planning_demo_node separately and thus prevented it from being exported as part of the hybrid planning dependency and by updating the exported include directory.
Furthermore, I removed the
getTargetWayPointIndexfunction from the abstract class because I think it is not essential and can be added to the child class if required. I became aware that we only define it in the SimpleSampler class but never use it anywhere (except I've overlooked it somewhere). @AndyZe maybe it can be removed completely what do you think?Checklist