Skip to content

Support including the names of other attached objects in touch_link (backport #3276)#3287

Merged
sea-bass merged 3 commits intohumblefrom
mergify/bp/humble/pr-3276
Jan 31, 2025
Merged

Support including the names of other attached objects in touch_link (backport #3276)#3287
sea-bass merged 3 commits intohumblefrom
mergify/bp/humble/pr-3276

Conversation

@mergify
Copy link
Copy Markdown

@mergify mergify bot commented Jan 31, 2025

Description

Fixes #3275. See that RFE for motivation and discussion of pros/cons and alternative approaches.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

This is an automatic backport of pull request #3276 done by [Mergify](https://mergify.com).

Aleksey Nogin and others added 2 commits January 31, 2025 13:26
…#3276)

* Support including the names of other attached objects in `touch_link`

Fixes #3275

* Add a comment; add {} for readability

---------

Co-authored-by: Sebastian Jahr <sebastian.jahr@picknik.ai>
(cherry picked from commit 75fb28b)
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 31, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 51.40%. Comparing base (343b897) to head (d0239da).
Report is 1 commits behind head on humble.

Files with missing lines Patch % Lines
...e/collision_detection_fcl/src/collision_common.cpp 0.00% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           humble    #3287      +/-   ##
==========================================
- Coverage   51.41%   51.40%   -0.01%     
==========================================
  Files         382      382              
  Lines       31894    31899       +5     
==========================================
- Hits        16395    16393       -2     
- Misses      15499    15506       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sea-bass sea-bass merged commit ce42d73 into humble Jan 31, 2025
7 checks passed
@sea-bass sea-bass deleted the mergify/bp/humble/pr-3276 branch January 31, 2025 16:11
github-merge-queue bot pushed a commit that referenced this pull request Feb 6, 2025
* Add joints_allowed_start_tolerance parameter (moveit/moveit#3287)
... for joint-specific start tolerances for TrajectoryExecutionManager

Co-authored-by: Robert Haschke <rhaschke@techfak.uni-bielefeld.de>

* Port to moveit2

* Allow joints_allowed_start_tolerance to be updated dynamically

* Apply formatting

* Rename joints_allowed_start_tolerance to allowed_start_tolerance_joints

---------

Co-authored-by: Hugal31 <hugo.laloge@gmail.com>
Co-authored-by: Robert Haschke <rhaschke@techfak.uni-bielefeld.de>
mergify bot pushed a commit that referenced this pull request Feb 6, 2025
* Add joints_allowed_start_tolerance parameter (moveit/moveit#3287)
... for joint-specific start tolerances for TrajectoryExecutionManager

Co-authored-by: Robert Haschke <rhaschke@techfak.uni-bielefeld.de>

* Port to moveit2

* Allow joints_allowed_start_tolerance to be updated dynamically

* Apply formatting

* Rename joints_allowed_start_tolerance to allowed_start_tolerance_joints

---------

Co-authored-by: Hugal31 <hugo.laloge@gmail.com>
Co-authored-by: Robert Haschke <rhaschke@techfak.uni-bielefeld.de>
(cherry picked from commit 9922704)
sea-bass pushed a commit that referenced this pull request Feb 6, 2025
)

* Add joints_allowed_start_tolerance parameter (moveit/moveit#3287)
... for joint-specific start tolerances for TrajectoryExecutionManager

Co-authored-by: Robert Haschke <rhaschke@techfak.uni-bielefeld.de>

* Port to moveit2

* Allow joints_allowed_start_tolerance to be updated dynamically

* Apply formatting

* Rename joints_allowed_start_tolerance to allowed_start_tolerance_joints

---------

Co-authored-by: Hugal31 <hugo.laloge@gmail.com>
Co-authored-by: Robert Haschke <rhaschke@techfak.uni-bielefeld.de>
(cherry picked from commit 9922704)

Co-authored-by: Daniel García López <d.garcialopez@hotmail.com>
sussybot5258 pushed a commit to GreyCatAI/moveit2 that referenced this pull request Apr 19, 2025
…it#3309)

* Add joints_allowed_start_tolerance parameter (moveit/moveit#3287)
... for joint-specific start tolerances for TrajectoryExecutionManager

Co-authored-by: Robert Haschke <rhaschke@techfak.uni-bielefeld.de>

* Port to moveit2

* Allow joints_allowed_start_tolerance to be updated dynamically

* Apply formatting

* Rename joints_allowed_start_tolerance to allowed_start_tolerance_joints

---------

Co-authored-by: Hugal31 <hugo.laloge@gmail.com>
Co-authored-by: Robert Haschke <rhaschke@techfak.uni-bielefeld.de>
Markus-Simonsen pushed a commit to Markus-Simonsen/moveit2 that referenced this pull request Aug 12, 2025
…it#3309)

* Add joints_allowed_start_tolerance parameter (moveit/moveit#3287)
... for joint-specific start tolerances for TrajectoryExecutionManager

Co-authored-by: Robert Haschke <rhaschke@techfak.uni-bielefeld.de>

* Port to moveit2

* Allow joints_allowed_start_tolerance to be updated dynamically

* Apply formatting

* Rename joints_allowed_start_tolerance to allowed_start_tolerance_joints

---------

Co-authored-by: Hugal31 <hugo.laloge@gmail.com>
Co-authored-by: Robert Haschke <rhaschke@techfak.uni-bielefeld.de>
helen9975 pushed a commit to personalrobotics/moveit2 that referenced this pull request Feb 17, 2026
…it#3309)

* Add joints_allowed_start_tolerance parameter (moveit/moveit#3287)
... for joint-specific start tolerances for TrajectoryExecutionManager

Co-authored-by: Robert Haschke <rhaschke@techfak.uni-bielefeld.de>

* Port to moveit2

* Allow joints_allowed_start_tolerance to be updated dynamically

* Apply formatting

* Rename joints_allowed_start_tolerance to allowed_start_tolerance_joints

---------

Co-authored-by: Hugal31 <hugo.laloge@gmail.com>
Co-authored-by: Robert Haschke <rhaschke@techfak.uni-bielefeld.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants