Add allowed_start_tolerance_joints parameter (Port moveit#3287) (backport #3309)#3328
Merged
Add allowed_start_tolerance_joints parameter (Port moveit#3287) (backport #3309)#3328
Conversation
* Add joints_allowed_start_tolerance parameter (moveit/moveit#3287) ... for joint-specific start tolerances for TrajectoryExecutionManager Co-authored-by: Robert Haschke <rhaschke@techfak.uni-bielefeld.de> * Port to moveit2 * Allow joints_allowed_start_tolerance to be updated dynamically * Apply formatting * Rename joints_allowed_start_tolerance to allowed_start_tolerance_joints --------- Co-authored-by: Hugal31 <hugo.laloge@gmail.com> Co-authored-by: Robert Haschke <rhaschke@techfak.uni-bielefeld.de> (cherry picked from commit 9922704)
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## jazzy #3328 +/- ##
==========================================
- Coverage 44.15% 44.14% -0.00%
==========================================
Files 700 700
Lines 61683 61727 +44
Branches 7477 7487 +10
==========================================
+ Hits 27229 27246 +17
- Misses 34286 34313 +27
Partials 168 168 ☔ View full report in Codecov by Sentry. |
sea-bass
approved these changes
Feb 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allow to specify a per joint allowed start tolerance for the TrajectoryExecutionManager. Port from moveit/moveit#3287 with some changes to be able to dynamically update its values at runtime.
Example of usage
In
moveit_controllers.yaml:Joints that are not declared in
allowed_start_tolerance_jointswill useallowed_start_toleranceas the default.Some remarks
I would personally have named this parameter "allowed_start_tolerance_joints" to be next to "allowed_start_tolerance" when sorted alphabetically. However, to maintain continuity with the original PR, I kept it as is.test_execution_manager.cppis not used at the moment, right?allowed_start_tolerance, it would be more intuitive to use the absolute value in that case.Checklist
This is an automatic backport of pull request #3309 done by [Mergify](https://mergify.com).