Remove Humble and Iron from tutorial Docker CI job#3081
Merged
Conversation
6 tasks
Contributor
|
Thanks for doing this! Those failing workflows have been irking me in recent PRs 😅 Happy to close #3078 with this |
rhaschke
approved these changes
Nov 11, 2024
Contributor
rhaschke
left a comment
There was a problem hiding this comment.
If you don't plan to make them working, these should be removed here. I agree.
Contributor
Author
I am moving the job for Humble to the As for Iron? The tutorials haven't really worked on that version for a while (there isn't even an |
Markus-Simonsen
pushed a commit
to Markus-Simonsen/moveit2
that referenced
this pull request
Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
These jobs have been failing as optional for a while, and the
mainbranch ofmoveit2just will not work with these older tutorial versions. So I opt for removing them here.If anything, the tutorial job should be added into the
humblebranch to test that specific pipeline -- doing in #3082.Checklist