Skip to content

[Humble] Add tutorial docker CI job and remove ci-testing job#3082

Merged
sjahr merged 7 commits intohumblefrom
add-tutorial-docker-ci-humble
Nov 14, 2024
Merged

[Humble] Add tutorial docker CI job and remove ci-testing job#3082
sjahr merged 7 commits intohumblefrom
add-tutorial-docker-ci-humble

Conversation

@sea-bass
Copy link
Copy Markdown
Contributor

@sea-bass sea-bass commented Nov 11, 2024

Description

This PR adds the tutorial docker CI job specific to Humble, which was removed from main in #3081.

It also removes the ci-testing Docker build from this branch, since the osrf/ros2:testing image is now on Ubuntu 24.04 and does not have the humble ROS binaries.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@sea-bass sea-bass changed the base branch from main to humble November 11, 2024 13:39
@mergify
Copy link
Copy Markdown

mergify bot commented Nov 11, 2024

Please target the main branch for development, we will backport the changes to humble for you if approved and if they don't break API.

@sea-bass sea-bass changed the title Add tutorial docker ci humble Add tutorial docker CI job to Humble Nov 11, 2024
@sea-bass sea-bass closed this Nov 11, 2024
@sea-bass sea-bass reopened this Nov 11, 2024
@sea-bass sea-bass marked this pull request as draft November 11, 2024 13:42
@sea-bass sea-bass marked this pull request as ready for review November 11, 2024 14:49
@sea-bass sea-bass requested review from rhaschke and sjahr November 11, 2024 14:49
@sea-bass sea-bass changed the title Add tutorial docker CI job to Humble Add tutorial docker CI job to, and remove ci-testing job from, Humble Nov 11, 2024
@sea-bass sea-bass changed the title Add tutorial docker CI job to, and remove ci-testing job from, Humble [Humble] Add tutorial docker CI job and remove ci-testing job Nov 11, 2024
@sea-bass sea-bass closed this Nov 11, 2024
@sea-bass sea-bass reopened this Nov 11, 2024
@sea-bass
Copy link
Copy Markdown
Contributor Author

sea-bass commented Nov 11, 2024

@sjahr Do you have the powers to remove the "Required" tag from the CI jobs that I've removed here?

Or rather, replace it with the new one?

@sea-bass sea-bass force-pushed the add-tutorial-docker-ci-humble branch from 453ea72 to 2456deb Compare November 11, 2024 23:56
@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.25%. Comparing base (ccf7e5c) to head (2456deb).
Report is 6 commits behind head on humble.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           humble    #3082      +/-   ##
==========================================
+ Coverage   51.15%   51.25%   +0.10%     
==========================================
  Files         382      382              
  Lines       31902    31865      -37     
==========================================
+ Hits        16317    16328      +11     
+ Misses      15585    15537      -48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs adaption of the required CI jobs. Unfortunately, I don't have permissions to change those either.

@sjahr sjahr merged commit f77a05b into humble Nov 14, 2024
@sjahr sjahr deleted the add-tutorial-docker-ci-humble branch November 14, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants