Skip to content

Fix key duplication in moveit_setup_assistant for moveit_controllers.yaml for typeFollowJointTrajectory#2959

Merged
sjahr merged 1 commit intomoveit:mainfrom
cschindlbeck:fix-key-duplication
Aug 9, 2024
Merged

Fix key duplication in moveit_setup_assistant for moveit_controllers.yaml for typeFollowJointTrajectory#2959
sjahr merged 1 commit intomoveit:mainfrom
cschindlbeck:fix-key-duplication

Conversation

@cschindlbeck
Copy link
Contributor

@cschindlbeck cschindlbeck commented Aug 9, 2024

Description

Moveit Setup Assistant generates duplicated keys action_ns, default for the type FollowJointTrajectory, e.g.

# MoveIt uses this configuration for controller management

moveit_controller_manager: moveit_simple_controller_manager/MoveItSimpleControllerManager

moveit_simple_controller_manager:
  controller_names:
    - steering_controller

  steering_controller:
    type: FollowJointTrajectory
    action_ns: follow_joint_trajectory
    default: true
    joints:
      - front_left_steer_joint
      - front_right_steer_joint
    action_ns: follow_joint_trajectory
    default: true

This PR deletes the redundant keys

@sjahr sjahr merged commit f8738b2 into moveit:main Aug 9, 2024
@jimmy-mcelwain jimmy-mcelwain mentioned this pull request Feb 5, 2025
Closed
@sea-bass sea-bass added the backport-humble Mergify label that triggers a PR backport to Humble label Feb 5, 2025
mergify bot pushed a commit that referenced this pull request Feb 5, 2025
@cschindlbeck @mergify
Fix key duplication in moveit_setup_assistant for FollowJointTrajecto…
85beca4 
…ry (#2959)

(cherry picked from commit f8738b2)
@mergify mergify bot mentioned this pull request Feb 5, 2025
Merged
sea-bass pushed a commit that referenced this pull request Feb 5, 2025
@mergify @cschindlbeck
Fix key duplication in moveit_setup_assistant for FollowJointTrajecto…
77b646e 
…ry (#2959) (#3316)

(cherry picked from commit f8738b2)

Co-authored-by: Chris Schindlbeck <chris.schindlbeck@gmail.com>
@sea-bass sea-bass mentioned this pull request Apr 13, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhaschke rhaschke rhaschke approved these changes

@sjahr sjahr sjahr approved these changes

Assignees

No one assigned

Labels

backport-humble Mergify label that triggers a PR backport to Humble

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cschindlbeck @rhaschke @sjahr @sea-bass