Skip to content

Fix key duplication in moveit_setup_assistant for moveit_controllers.yaml for typeFollowJointTrajectory (backport #2959)#3316

Merged
sea-bass merged 1 commit intohumblefrom
mergify/bp/humble/pr-2959
Feb 5, 2025
Merged

Fix key duplication in moveit_setup_assistant for moveit_controllers.yaml for typeFollowJointTrajectory (backport #2959)#3316
sea-bass merged 1 commit intohumblefrom
mergify/bp/humble/pr-2959

Conversation

@mergify
Copy link

@mergify mergify bot commented Feb 5, 2025

Description

Moveit Setup Assistant generates duplicated keys action_ns, default for the type FollowJointTrajectory, e.g.

# MoveIt uses this configuration for controller management

moveit_controller_manager: moveit_simple_controller_manager/MoveItSimpleControllerManager

moveit_simple_controller_manager:
  controller_names:
    - steering_controller

  steering_controller:
    type: FollowJointTrajectory
    action_ns: follow_joint_trajectory
    default: true
    joints:
      - front_left_steer_joint
      - front_right_steer_joint
    action_ns: follow_joint_trajectory
    default: true

This PR deletes the redundant keys


This is an automatic backport of pull request #2959 done by Mergify.

@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.40%. Comparing base (77dde32) to head (85beca4).
Report is 1 commits behind head on humble.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           humble    #3316      +/-   ##
==========================================
+ Coverage   51.40%   51.40%   +0.01%     
==========================================
  Files         382      382              
  Lines       31899    31896       -3     
==========================================
- Hits        16393    16392       -1     
+ Misses      15506    15504       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sea-bass sea-bass merged commit 77b646e into humble Feb 5, 2025
7 checks passed
@sea-bass sea-bass deleted the mergify/bp/humble/pr-2959 branch February 5, 2025 23:46
@zacharyyamaoka
Copy link

@sea-bass

I think this may be causing an undesirable default behaviour.

Now if you don't specify the action namespace and default in the setup assitant, they won't be generated!

and planning execution won't work out of the box!

moveit_simple_controller_manager:
  controller_names:
    - arm_controller
    - eef_controller

  arm_controller:
    type: FollowJointTrajectory
    joints:
      - right_joint_1
      - right_joint_2
      - right_joint_3
      - right_joint_4
      - right_joint_5
      - right_joint_6
  eef_controller:
    type: FollowJointTrajectory
    joints:
      - right_joint_6

^ no action_ns added by default

[move_group-3] [ERROR] [1744412852.441687230] [move_group.moveit.moveit.plugins.simple_controller_manager]: No action namespace specified for controller `arm_controller` through parameter `moveit_simple_controller_manager.arm_controller.action_ns`
[move_group-3] [INFO] [1744412852.441806768] [move_group.moveit.moveit.plugins.simple_controller_manager]: Returned 0 controllers in list
[move_group-3] [INFO] [1744412852.441815254] [move_group.moveit.moveit.plugins.simple_controller_manager]: Returned 0 controllers in list

@sea-bass
Copy link
Contributor

sea-bass commented Apr 11, 2025

I just backported this from #2959, but good to know -- thanks!

Would be great if you could put up a PR to address this in both the unspecified and specified cases (probably needs some if-condition).

Or at least it would be appreciated if you put up a new Git issue so someone can see it and work on it.

@sea-bass
Copy link
Contributor

@zacharyyamaoka I created #3434

@zacharyyamaoka
Copy link

@zacharyyamaoka I created #3434

Thank you!!! sorry for slow response on this. I did some more testing on this just now and I will post there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MoveIt Setup Assistant does not honor action_ns or default values

4 participants