Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## humble #3316 +/- ##
==========================================
+ Coverage 51.40% 51.40% +0.01%
==========================================
Files 382 382
Lines 31899 31896 -3
==========================================
- Hits 16393 16392 -1
+ Misses 15506 15504 -2 ☔ View full report in Codecov by Sentry. |
|
I think this may be causing an undesirable default behaviour. Now if you don't specify the action namespace and default in the setup assitant, they won't be generated! and planning execution won't work out of the box! ^ no action_ns added by default |
|
I just backported this from #2959, but good to know -- thanks! Would be great if you could put up a PR to address this in both the unspecified and specified cases (probably needs some if-condition). Or at least it would be appreciated if you put up a new Git issue so someone can see it and work on it. |
|
@zacharyyamaoka I created #3434 |
Thank you!!! sorry for slow response on this. I did some more testing on this just now and I will post there |
Description
Moveit Setup Assistant generates duplicated keys action_ns, default for the type FollowJointTrajectory, e.g.
This PR deletes the redundant keys
This is an automatic backport of pull request #2959 done by Mergify.