Skip to content

CI: Allow non-interactive installation of rmw-connextdds#2790

Merged
rhaschke merged 1 commit intomoveit:humblefrom
rhaschke:humble
Apr 15, 2024
Merged

CI: Allow non-interactive installation of rmw-connextdds#2790
rhaschke merged 1 commit intomoveit:humblefrom
rhaschke:humble

Conversation

@rhaschke
Copy link
Contributor

When installing rmw-connextdds within a humble docker image, e.g. via rosdep, this fails, because interactive acceptance of the license is required despite common flags like --yes:
moveit/moveit_task_constructor#558
https://github.com/ros-planning/moveit_task_constructor/actions/runs/8680352798/job/23800710624#step:4:177

Declaring the environment variable RTI_NC_LICENSE_ACCEPTED=yes resolves that issue:
https://github.com/ros-planning/moveit_task_constructor/actions/runs/8680352798

@mergify
Copy link

mergify bot commented Apr 15, 2024

Please target the main branch for development, we will backport the changes to humble for you if approved and if they don't break API.

@sea-bass
Copy link
Contributor

Should this target main, as the bot says?

@rhaschke
Copy link
Contributor Author

Should this target main, as the bot says?

I don't know whether main/rolling is also affected by this issue. Currently, the rolling CI is broken for other reasons.
Thus, I explicitly targeted humble. I suggest to forward-port if needed.
Obviously, ikfast testing is broken here as well - due to outdated server keys. Does anybody maintain CI?

@rhaschke
Copy link
Contributor Author

Obviously, ikfast testing is broken here as well - due to outdated server keys.

I have a fix for this from MoveIt 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants