Re-enable clang-tidy check performance-unnecessary-value-param#1703
Merged
henningkayser merged 2 commits intomoveit:mainfrom Nov 9, 2022
Merged
Re-enable clang-tidy check performance-unnecessary-value-param#1703henningkayser merged 2 commits intomoveit:mainfrom
performance-unnecessary-value-param#1703henningkayser merged 2 commits intomoveit:mainfrom
Conversation
... after moveit#214 was fixed in rclcpp.
JafarAbdi
approved these changes
Nov 9, 2022
vatanaksoytezer
approved these changes
Nov 9, 2022
Codecov ReportBase: 50.97% // Head: 50.97% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1703 +/- ##
=======================================
Coverage 50.97% 50.97%
=======================================
Files 378 378
Lines 31649 31649
=======================================
Hits 16131 16131
Misses 15518 15518 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
mergify bot
pushed a commit
that referenced
this pull request
Nov 9, 2022
(cherry picked from commit 72e29b4)
Contributor
Author
|
Let's see how many issues of this type were introduced during the last years: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... after #214 was fixed in rclcpp.