Apply missing clang-tidy fixes#215
Merged
henningkayser merged 4 commits intomoveit:masterfrom Jun 22, 2020
Merged
Conversation
c88f297 to
25af051
Compare
Codecov Report
@@ Coverage Diff @@
## master #215 +/- ##
==========================================
- Coverage 47.33% 47.33% -0.01%
==========================================
Files 143 143
Lines 13321 13319 -2
==========================================
- Hits 6305 6304 -1
+ Misses 7016 7015 -1
Continue to review full report at Codecov.
|
b46e6b6 to
3f13b04
Compare
b76d6d7 to
4166dfd
Compare
4166dfd to
9da9435
Compare
JafarAbdi
added a commit
to rhaschke/moveit2
that referenced
this pull request
Nov 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applied clang-tidy-fix over the full codebase to fix master branch CI.
I disabled
performance-unnecessary-value-paramto suppress fixes for callback functions (see #214), merely adding NOLINT really clutters up the code a lot as there are many multi-line functions.