Skip to content

Fix PlanarJointModel::satisfiesPositionBounds#1353

Merged
henningkayser merged 2 commits intomoveit:mainfrom
rcywongaa:Fix_PlanarJointModel_satisfiesPositionBounds
Jun 16, 2022
Merged

Fix PlanarJointModel::satisfiesPositionBounds#1353
henningkayser merged 2 commits intomoveit:mainfrom
rcywongaa:Fix_PlanarJointModel_satisfiesPositionBounds

Conversation

@rcywongaa
Copy link
Copy Markdown
Contributor

@rcywongaa rcywongaa commented Jun 13, 2022 •
edited
Loading

Description

Fixes PlanarJointModel::satisfiesPositionBounds to correctly check for all 3 positions instead of the 0-th position 3 times.

Replaces #1327

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@rcywongaa rcywongaa marked this pull request as ready for review June 13, 2022 21:10
@rcywongaa rcywongaa force-pushed the Fix_PlanarJointModel_satisfiesPositionBounds branch from 413d72d to 2083562 Compare June 13, 2022 21:10
JafarAbdi
JafarAbdi approved these changes Jun 13, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@JafarAbdi JafarAbdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

@JafarAbdi
Copy link
Copy Markdown
Member

JafarAbdi commented Jun 13, 2022

@rcywongaa Do you mind backporting it to https://github.com/ros-planning/moveit?

@rcywongaa rcywongaa mentioned this pull request Jun 13, 2022
Merged
6 tasks
@rcywongaa
Copy link
Copy Markdown
Contributor Author

rcywongaa commented Jun 13, 2022

@JafarAbdi Done 😄

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 13, 2022 •
edited
Loading

Codecov Report

Merging #1353 (d06d0cb) into main (990925e) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1353      +/-   ##
==========================================
+ Coverage   61.56%   61.57%   +0.01%     
==========================================
  Files         274      274              
  Lines       24966    24966              
==========================================
+ Hits        15369    15370       +1     
+ Misses       9597     9596       -1
Impacted Files Coverage Δ
moveit_core/robot_model/src/planar_joint_model.cpp 84.12% <100.00%> (ø)
...ma_kinematics_plugin/src/lma_kinematics_plugin.cpp 73.46% <0.00%> (-3.70%) ⬇️
...nning_scene_monitor/src/planning_scene_monitor.cpp 45.73% <0.00%> (+0.44%) ⬆️
...dl_kinematics_plugin/src/kdl_kinematics_plugin.cpp 76.43% <0.00%> (+1.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 990925e...d06d0cb. Read the comment docs.

@henningkayser henningkayser added backport-foxy Mergify label that triggers a PR backport to Foxy backport-galactic Mergify label that triggers a PR backport to Galactic backport-humble Mergify label that triggers a PR backport to Humble labels Jun 16, 2022
@henningkayser henningkayser merged commit 1c3e1ea into moveit:main Jun 16, 2022
@mergify mergify bot mentioned this pull request Jun 16, 2022
Merged
mergify bot pushed a commit that referenced this pull request Jun 16, 2022
@rcywongaa @mergify
Fix PlanarJointModel::satisfiesPositionBounds (#1353)
d0516b4 
Co-authored-by: Vatan Aksoy Tezer <vatan@picknik.ai>
(cherry picked from commit 1c3e1ea)
mergify bot pushed a commit that referenced this pull request Jun 16, 2022
@rcywongaa @mergify
Fix PlanarJointModel::satisfiesPositionBounds (#1353)
dcc12c9 
Co-authored-by: Vatan Aksoy Tezer <vatan@picknik.ai>
(cherry picked from commit 1c3e1ea)
@mergify mergify bot mentioned this pull request Jun 16, 2022
Merged
mergify bot pushed a commit that referenced this pull request Jun 16, 2022
@rcywongaa @mergify
Fix PlanarJointModel::satisfiesPositionBounds (#1353)
4c45890 
Co-authored-by: Vatan Aksoy Tezer <vatan@picknik.ai>
(cherry picked from commit 1c3e1ea)
@mergify mergify bot mentioned this pull request Jun 16, 2022
Merged
JafarAbdi pushed a commit that referenced this pull request Jun 16, 2022
@mergify @rcywongaa
Fix PlanarJointModel::satisfiesPositionBounds (#1353) (#1376)
949face 
(cherry picked from commit 1c3e1ea)

Co-authored-by: Rufus Wong <rcywongaa@gmail.com>
henningkayser pushed a commit that referenced this pull request Jun 16, 2022
@mergify @rcywongaa
Fix PlanarJointModel::satisfiesPositionBounds (#1353) (#1378)
e15aa66 
Co-authored-by: Vatan Aksoy Tezer <vatan@picknik.ai>
(cherry picked from commit 1c3e1ea)

Co-authored-by: Rufus Wong <rcywongaa@gmail.com>
henningkayser pushed a commit that referenced this pull request Jun 16, 2022
@mergify @rcywongaa
Fix PlanarJointModel::satisfiesPositionBounds (#1353) (#1377)
5595b0a 
Co-authored-by: Vatan Aksoy Tezer <vatan@picknik.ai>
(cherry picked from commit 1c3e1ea)

Co-authored-by: Rufus Wong <rcywongaa@gmail.com>
peterdavidfagan pushed a commit to peterdavidfagan/moveit2 that referenced this pull request Jul 14, 2022
@rcywongaa @peterdavidfagan
Fix PlanarJointModel::satisfiesPositionBounds (moveit#1353)
442840a 
Co-authored-by: Vatan Aksoy Tezer <vatan@picknik.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@henningkayser henningkayser henningkayser approved these changes

@JafarAbdi JafarAbdi JafarAbdi approved these changes

+1 more reviewer

@vatanaksoytezer vatanaksoytezer vatanaksoytezer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport-foxy Mergify label that triggers a PR backport to Foxy backport-galactic Mergify label that triggers a PR backport to Galactic backport-humble Mergify label that triggers a PR backport to Humble

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rcywongaa @JafarAbdi @henningkayser @vatanaksoytezer