Remove repeated checking of same value#1327
Closed
rcywongaa wants to merge 1 commit intomoveit:mainfrom
Closed
Conversation
tylerjw
reviewed
Jun 7, 2022
Comment on lines
+273
to
+276
| if (values[0] < bounds[0].min_position_ - margin || values[0] > bounds[0].max_position_ + margin) | ||
| return false; | ||
| else | ||
| return true; |
Member
There was a problem hiding this comment.
Is there any guarantee that values and bounds have at least one value? This looks like a segfault in waiting.
Member
There was a problem hiding this comment.
Does it also seem like it is more likely that the intent was to use the index i somehow than to check the first element 3 times?
Contributor
Author
|
I'll close this for now until I clarify what this function is supposed to do... |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While the repeated checking of the same value seems likely wrong, I wonder if this function is doing what it claims. Seems to be checking whether a scalar is within bounds of a vector[3].
Checklist