Skip to content

Remove manipulation from moveit_ros#1177

Merged
henningkayser merged 2 commits intomoveit:mainfrom
stephanie-eng:seng/remove_manipulation
Jun 16, 2022
Merged

Remove manipulation from moveit_ros#1177
henningkayser merged 2 commits intomoveit:mainfrom
stephanie-eng:seng/remove_manipulation

Conversation

@stephanie-eng
Copy link
Contributor

@stephanie-eng stephanie-eng commented Apr 12, 2022

Description

Remove manipulation package as per #1038

@stephanie-eng stephanie-eng marked this pull request as draft April 12, 2022 14:58
@codecov
Copy link

codecov bot commented Apr 12, 2022 •
edited
Loading

Codecov Report

Merging #1177 (29fa6a8) into main (4a16b05) will decrease coverage by 0.37%.
The diff coverage is n/a.

❗ Current head 29fa6a8 differs from pull request most recent head 5bb2010. Consider uploading reports for the commit 5bb2010 to get more accurate results

@@            Coverage Diff             @@
##             main    #1177      +/-   ##
==========================================
- Coverage   61.56%   61.20%   -0.36%     
==========================================
  Files         274      274              
  Lines       24965    24825     -140     
==========================================
- Hits        15368    15192     -176     
- Misses       9597     9633      +36
Impacted Files Coverage Δ
...e/src/parameterization/model_based_state_space.cpp 68.33% <0.00%> (-18.01%) ⬇️
...terface/parameterization/model_based_state_space.h 87.18% <0.00%> (-10.25%) ⬇️
moveit_core/planning_scene/src/planning_scene.cpp 48.84% <0.00%> (-3.68%) ⬇️
moveit_core/robot_model/src/joint_model_group.cpp 61.92% <0.00%> (-1.96%) ⬇️
...src/bullet_integration/bullet_cast_bvh_manager.cpp 51.43% <0.00%> (-1.42%) ⬇️
...tance_field/src/collision_distance_field_types.cpp 34.79% <0.00%> (-0.86%) ⬇️
...mpl_interface/src/model_based_planning_context.cpp 51.21% <0.00%> (-0.29%) ⬇️
.../src/bullet_integration/contact_checker_common.cpp 84.51% <0.00%> (-0.21%) ⬇️
moveit_core/robot_state/src/robot_state.cpp 47.29% <0.00%> (-0.15%) ⬇️
...raint_samplers/src/default_constraint_samplers.cpp 71.75% <0.00%> (-0.07%) ⬇️
... and 70 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a16b05...5bb2010. Read the comment docs.

@stephanie-eng stephanie-eng force-pushed the seng/remove_manipulation branch from 87b6b29 to 9ef5ff8 Compare April 12, 2022 19:51
@mergify
Copy link

mergify bot commented Apr 12, 2022

This pull request is in conflict. Could you fix it @stephanie-eng?

@stephanie-eng stephanie-eng force-pushed the seng/remove_manipulation branch from 9ef5ff8 to 3b9ed7f Compare April 22, 2022 14:47
@stephanie-eng stephanie-eng marked this pull request as ready for review April 22, 2022 17:07
@AndyZe
Copy link
Member

AndyZe commented Apr 23, 2022 •
edited
Loading

If you do some grepping, it looks like there are still some references to moveit_ros_manipulation to be removed. For example,

move_group/src/move_group.cpp:    // TODO (ddengster) : wait for port for moveit_ros_manipulation package
planning_interface/move_group_interface/src/move_group_interface.cpp:// TODO(JafarAbdi): Enable once moveit_ros_manipulation is ported
planning_interface/move_group_interface/src/move_group_interface.cpp:    // TODO(JafarAbdi): Enable once moveit_ros_manipulation is ported
planning_interface/CMakeLists.txt:# find_package(moveit_ros_manipulation REQUIRED)
planning_interface/CMakeLists.txt:#  moveit_ros_manipulation
planning_interface/package.xml:  <!-- TODO(JafarAbdi): uncomment after porting moveit_ros_manipulation -->
planning_interface/package.xml:  <!--depend>moveit_ros_manipulation</depend-->

@stephanie-eng stephanie-eng force-pushed the seng/remove_manipulation branch from 6ccb229 to 1113420 Compare April 25, 2022 14:29
AndyZe
AndyZe reviewed Apr 25, 2022
View reviewed changes
Copy link
Member

@AndyZe AndyZe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more reference to remove:

moveit_ros/planning_interface/CMakeLists.txt:# find_package(moveit_ros_manipulation REQUIRED)

AndyZe
AndyZe approved these changes Apr 25, 2022
View reviewed changes
Copy link
Member

@AndyZe AndyZe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving provided the last reference to moveit_ros_manipulation gets removed 👍

@stephanie-eng stephanie-eng force-pushed the seng/remove_manipulation branch 2 times, most recently from fe3593e to 7e38547 Compare April 25, 2022 16:09
@mergify
Copy link

mergify bot commented May 10, 2022

This pull request is in conflict. Could you fix it @stephanie-eng?

@stephanie-eng stephanie-eng force-pushed the seng/remove_manipulation branch from 7e38547 to 29fa6a8 Compare May 10, 2022 14:49
@mergify
Copy link

mergify bot commented Jun 13, 2022

This pull request is in conflict. Could you fix it @stephanie-eng?

@henningkayser henningkayser force-pushed the seng/remove_manipulation branch from 29fa6a8 to 5bb2010 Compare June 16, 2022 18:43
@henningkayser henningkayser merged commit fe72522 into moveit:main Jun 16, 2022
peterdavidfagan pushed a commit to peterdavidfagan/moveit2 that referenced this pull request Jul 14, 2022
@stephanie-eng @peterdavidfagan
Remove manipulation from moveit_ros (moveit#1177)
dc26e58
@henningkayser henningkayser mentioned this pull request Mar 10, 2023
Closed
mikeferguson added a commit to mikeferguson/moveit2 that referenced this pull request Oct 10, 2024
@mikeferguson
remove dead pick and place code
a39a137 
most of the other stuff was removed as part of moveit#1177
@mikeferguson mikeferguson mentioned this pull request Oct 10, 2024
Merged
6 tasks
sjahr pushed a commit that referenced this pull request Oct 11, 2024
@mikeferguson
remove dead pick and place code (#3025)
865ad36 
most of the other stuff was removed as part of #1177
Markus-Simonsen pushed a commit to Markus-Simonsen/moveit2 that referenced this pull request Aug 12, 2025
@mikeferguson
remove dead pick and place code (moveit#3025)
fa7da54 
most of the other stuff was removed as part of moveit#1177
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@henningkayser henningkayser henningkayser approved these changes

@AndyZe AndyZe AndyZe approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stephanie-eng @AndyZe @henningkayser