Closed
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1163 +/- ##
==========================================
+ Coverage 59.76% 61.03% +1.27%
==========================================
Files 274 274
Lines 24749 24749
==========================================
+ Hits 14789 15102 +313
+ Misses 9960 9647 -313
Continue to review full report at Codecov.
|
DLu
suggested changes
Apr 4, 2022
moveit_ros/moveit_servo/test/launch/test_servo_pose_tracking.test.py
Outdated
Show resolved
Hide resolved
moveit_ros/planning_interface/test/launch/move_group_launch_test_common.py
Outdated
Show resolved
Hide resolved
DLu
approved these changes
Apr 4, 2022
Contributor
|
Seems something wrong with rmw implementation in testing. Will investigate |
Contributor
|
Until this PR get merged, everything will be blocked since we merged the moveit_resources PR, which is breaking. If we can't resolve the CI issue in testing, I will add a specific version of moveit_resources. |
6 tasks
Contributor
|
I could not replicate this test failure on focal. |
Contributor
|
Working on some fixes here: vatanaksoytezer#26 |
Contributor
|
Merged with #1170. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should be merged along with these PR's in other repos:
moveit_resources: moveit/moveit_resources#127
moveit_tutorials: moveit/moveit2_tutorials#343 (comment)
@DLu is leading the charge on this, but I think the idea is to give the arm and the gripper a standard name that makes sense and can be used by Jafar's simplified launch module. Previously both MoveIt and ros_control config files were often named
controller.yaml.