Skip to content

Disable failing rdf test, merge #1163 and #1168#1170

Merged
henningkayser merged 4 commits intomoveit:mainfrom
vatanaksoytezer:vatan/disable_rdf_fix_ci
Apr 7, 2022
Merged

Disable failing rdf test, merge #1163 and #1168#1170
henningkayser merged 4 commits intomoveit:mainfrom
vatanaksoytezer:vatan/disable_rdf_fix_ci

Conversation

@vatanaksoytezer
Copy link
Copy Markdown
Contributor

@vatanaksoytezer vatanaksoytezer commented Apr 6, 2022 •
edited
Loading

I think this is the only way to fix the CI, in one single PR. Just want to get this in and unblock everything here.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 6, 2022 •
edited
Loading

Codecov Report

Merging #1170 (0804c0d) into main (99939d3) will increase coverage by 1.52%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1170      +/-   ##
==========================================
+ Coverage   59.76%   61.27%   +1.52%     
==========================================
  Files         274      274              
  Lines       24749    24756       +7     
==========================================
+ Hits        14789    15168     +379     
+ Misses       9960     9588     -372
Impacted Files Coverage Δ
...lanners/ompl/ompl_interface/src/ompl_interface.cpp 0.00% <0.00%> (ø)
..._core/collision_detection/src/collision_common.cpp 50.00% <0.00%> (-50.00%) ⬇️
...e/collision_detection_fcl/src/collision_common.cpp 73.76% <0.00%> (+0.23%) ⬆️
moveit_core/robot_state/src/robot_state.cpp 47.28% <0.00%> (+0.32%) ⬆️
moveit_core/planning_scene/src/planning_scene.cpp 48.84% <0.00%> (+0.59%) ⬆️
moveit_ros/moveit_servo/src/servo_calcs.cpp 67.40% <0.00%> (+2.53%) ⬆️
...or/src/current_state_monitor_middleware_handle.cpp 88.24% <0.00%> (+5.89%) ⬆️
moveit_ros/moveit_servo/src/collision_check.cpp 86.16% <0.00%> (+6.16%) ⬆️
...nning_scene_monitor/src/planning_scene_monitor.cpp 46.50% <0.00%> (+6.57%) ⬆️
moveit_ros/moveit_servo/src/servo.cpp 75.00% <0.00%> (+12.50%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99939d3...0804c0d. Read the comment docs.

@vatanaksoytezer vatanaksoytezer requested review from AndyZe, DLu, JafarAbdi and henningkayser and removed request for DLu April 6, 2022 23:35
DLu
DLu reviewed Apr 7, 2022
View reviewed changes
DLu
DLu reviewed Apr 7, 2022
View reviewed changes
@DLu DLu mentioned this pull request Apr 7, 2022
Closed
AndyZe
AndyZe approved these changes Apr 7, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@AndyZe AndyZe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but can you please do an interactive rebase to squash it into about 3 commits? I would think:

  1. rename panda controllers
  2. Revert OMPL parameter loading
  3. Comment failing test

Thanks! I can imagine how much work it was to track this all down.

@vatanaksoytezer vatanaksoytezer force-pushed the vatan/disable_rdf_fix_ci branch from b40a74b to 7c0b270 Compare April 7, 2022 15:11
@vatanaksoytezer
Copy link
Copy Markdown
Contributor Author

vatanaksoytezer commented Apr 7, 2022

LGTM but can you please do an interactive rebase to squash it into about 3 commits? I would think:

Done! @AndyZe Would you like to squash merge this or merge the commits seperately?

@AndyZe
Copy link
Copy Markdown
Member

AndyZe commented Apr 7, 2022

Separate commits is better 👍

JafarAbdi
JafarAbdi approved these changes Apr 7, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@JafarAbdi JafarAbdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

If you don't mind I'll spend 30mins trying to fix the segfault before we merge this

@vatanaksoytezer
Copy link
Copy Markdown
Contributor Author

vatanaksoytezer commented Apr 7, 2022

LGTM

If you don't mind I'll spend 30mins trying to fix the segfault before we merge this

Sure, I'm happy with that.

@AndyZe
Copy link
Copy Markdown
Member

AndyZe commented Apr 7, 2022

@henningkayser do you want to squash and merge this or can you keep the individual commits? It is urgently needed to fix CI.

@henningkayser henningkayser merged commit f8da951 into moveit:main Apr 7, 2022
This was referenced Apr 7, 2022
Closed
Closed
@henningkayser henningkayser mentioned this pull request Aug 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@henningkayser henningkayser henningkayser approved these changes

@AndyZe AndyZe AndyZe approved these changes

@JafarAbdi JafarAbdi JafarAbdi approved these changes

+1 more reviewer

@DLu DLu DLu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vatanaksoytezer @AndyZe @DLu @henningkayser @JafarAbdi