Rename Panda Controller Files#127
Merged
vatanaksoytezer merged 2 commits intomoveit:ros2from Apr 5, 2022
Merged
Conversation
Member
|
This is going to break setups in moveit2_tutorials :( and maybe the moveit2 repo as well. I can make corresponding PR's there to reduce the breakage over the weekend. |
This was referenced Mar 29, 2022
|
Agreed with Andy here. Happy to merge once we make sure we don't break moveit2 and moveit2 tutorials. |
AndyZe
approved these changes
Apr 2, 2022
Member
AndyZe
left a comment
There was a problem hiding this comment.
I verified that this works and you didn't miss any renamings.
Needs to be merged with:
moveit_tutorials: moveit/moveit2_tutorials#343
moveit2: moveit/moveit2#1163
JafarAbdi
approved these changes
Apr 4, 2022
vatanaksoytezer
approved these changes
Apr 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Via conversation on #124
CC: @AndyZe