Merged
Conversation
... to indicate transfer of ownership and simplify pointer handling
... reducing code duplication and facilitating re-use
... because the former will consider future collision entries as well.
- Serialize full current state (previously pairs with a default, but no entry were skipped) - Only initialize matrix entries that deviate from the default.
@v4hn requested splitting of collision_pairs into (re)enabled and disabled.
This method is only used there to update disabled collision entries.
These tests are known to run for a very long time in debug builds. So let's disable them in this case. If you still insist to run them, you can do so via `locked_robot_state_test --gtest_also_run_disabled_tests`
…veit#3017) Co-authored-by: andreas-botbuilt <94128674+andreas-botbuilt@users.noreply.github.com>
- Add stomp planner to MSA - Add OMPL-CHOMP planner to MSA - Remove obsolete CHOMP parameters - Update CHOMP config parameters to match code defaults - Create CHOMP config via template (instead of code) Co-authored-by: Robert Haschke <rhaschke@techfak.uni-bielefeld.de>
Implement ACM defaults as a fallback instead of an override. Based on moveit/srdfdom#97, this allows disabling collisions for specific links/objects by default and re-enabling individual pairs if necessary.
|
This pull request is in conflict. Could you fix it @Abishalini? |
5601a06 to
9c61ebf
Compare
6 tasks
3ed91c9 to
4b20a59
Compare
705da08 to
01e67c1
Compare
Codecov Report
@@ Coverage Diff @@
## main #1151 +/- ##
==========================================
- Coverage 61.41% 61.29% -0.11%
==========================================
Files 271 274 +3
Lines 24754 24749 -5
==========================================
- Hits 15200 15168 -32
- Misses 9554 9581 +27
Continue to review full report at Codecov.
|
01e67c1 to
f7c59a7
Compare
6 tasks
JafarAbdi
approved these changes
Apr 4, 2022
Member
JafarAbdi
left a comment
There was a problem hiding this comment.
LGTM, not sure what's wrong with clang-tidy
6 tasks
vatanaksoytezer
approved these changes
Apr 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Sync the following commits from MoveIt
Checklist