Fix handling of sensors_3d.yaml#2946
Merged
rhaschke merged 1 commit intomoveit:masterfrom Nov 5, 2021
Merged
Conversation
- Reading both, the default and the existing package's sensors_3d.yaml
into the config, the config file was growing by 2 configs each time.
- Not visiting the Perception tab, was writing the default config with 2 entries
- Selecting "None" was writing an invalid config:
sensors:
- {}
- {}
rhaschke
added a commit
to ubi-agni/moveit
that referenced
this pull request
Nov 5, 2021
This was referenced Nov 5, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The perception widget had several issues since its introduction in #969:
sensors_3d.yamlinto the config, the config file was growing by 2 configs each time.Perceptiontab, was writing the default config with 2 entries