Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2932 +/- ##
==========================================
- Coverage 61.73% 61.12% -0.61%
==========================================
Files 373 371 -2
Lines 33427 33408 -19
==========================================
- Hits 20634 20418 -216
- Misses 12793 12990 +197
Continue to review full report at Codecov.
|
Contributor
|
LGTM. Solves the fixed frame warning in the gazebo simulation, builds and works on ROS noetic and cleans up the MSA template. |
Gazebo requires a fixed joint from world to the first robot link. This resembles the virtual_joint of SRDF. However, the RobotModel parser issues the following warning: Skipping virtual joint 'xxx' because its child frame 'xxx' does not match the URDF frame 'world'
Fixes the following error (occurring since 61d18f2) ``` [FATAL] ros.moveit_ros_planning.trajectory_execution_manager: Exception while loading controller manager 'robot': According to the loaded plugin descriptions the class robot with base class type moveit_controller_manager::MoveItControllerManager does not exist. ``` As we introduced `pass_all_args="true"`, the value of the argument `moveit_controller_manager` was the robot name.
There are 3 basic MoveIt controller manager plugins: - fake = `moveit_fake_controller_manager::MoveItFakeControllerManager` Used in demo.launch. Doesn't really control the robot, but just interpolates between via points. Allows these execution_types: - via points: just jumps to the via points - interpolate: linearly interpolates between via points (default) - last point: jumps to the final trajectory point (used for fast execution testing) - ros_control = `moveit_ros_control_interface::MoveItControllerManager` Interfaces to ros_control controllers. - simple = `moveit_simple_controller_manager/MoveItSimpleControllerManager` Interfaces to action servers for `FollowJointTrajectory` and/or `GripperCommand` that in turn interface to the low-level robot controllers (typically based on ros_control) However, so far move_group.launch distinguished between `fake` and `robot` only. The argument moveit_controller_manager now allows switching between all 3 variants. Adding more *_moveit_controller_manager.launch files allows for an extension of this scheme.
3a9d849 to
08ba8a3
Compare
This will facilitate re-use of demo.launch.
Only unpause simulation when robot model was loaded. This ensures that the initial pose is actually held.
... to clarify that this parameter is only used for fake controllers
There is no means to declare the planning_plugin as an arg first.
fb1eaa8 to
170e6d2
Compare
This was referenced Nov 5, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses various issues I noticed when working on moveit/panda_moveit_config#89.
Skipping virtual joint 'xxx' because its child frame 'xxx' does not match the URDF frame 'world'execution_typeargument from real-robotcontroller_manager.launchas suggested in moveit_controller_manager.launch: pass execution_type via pass_all_args #2928 (comment)