Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2769 +/- ##
==========================================
- Coverage 60.17% 60.15% -0.01%
==========================================
Files 356 356
Lines 31321 31321
==========================================
- Hits 18844 18838 -6
- Misses 12477 12483 +6
Continue to review full report at Codecov.
|
v4hn
reviewed
Jul 16, 2021
| <!-- Run Rviz and load the default config to see the state of the move_group node --> | ||
| <include file="$(dirname)/moveit_rviz.launch" if="$(arg use_rviz)"> | ||
| <arg name="rviz_config" value="$(find [GENERATED_PACKAGE_NAME])/launch/moveit.rviz"/> | ||
| <arg name="rviz_config" value="$(dirname)/moveit.rviz"/> |
Contributor
There was a problem hiding this comment.
you are right, it actually works due to our file layout - even though the use is buggy and does not set a good example I guess.. . #2748 (comment)
Contributor
Author
There was a problem hiding this comment.
You are right. I ran into this bug recently as well. I will revert this change.
sjahr
pushed a commit
to sjahr/moveit
that referenced
this pull request
Jun 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Major change is to create a static_transform_publisher for each and every virtual joint type as suggested in moveit/moveit_resources#89 (comment).
Additionally, some minor formatting changes.