use $(dirname) in MoveIt Setup Assistant#2748
Conversation
Available since lunar. This simplifies the descriptions in moveit_resources quite a bit because their package name does not match the include path and we have to adapt the names everywhere after edits. Note that two candidates for this replacement still remain - they define the file path to the rviz config in an arg value. Due to [a bug](ros/ros_comm#1487) these two can not be replaced at this moment.
Codecov Report
@@ Coverage Diff @@
## master #2748 +/- ##
==========================================
- Coverage 60.51% 60.49% -0.02%
==========================================
Files 402 402
Lines 29659 29659
==========================================
- Hits 17944 17938 -6
- Misses 11715 11721 +6
Continue to review full report at Codecov.
|
gavanderhoorn
left a comment
There was a problem hiding this comment.
Looks ok to me.
I assume the main motivation is:
This simplifies the descriptions in moveit_resources quite a bit because their package name does not match the include path and we have to adapt the names everywhere after edits.
as there isn't anything too 'complex' about the expressions here in the MSA templates.
That's why I came up with the patch, yes. Also I believe it's the better approach for including launch files in the same folder anyway, but that alone would not justify the template changes. Thanks for the review. |
augmenting moveit#2748
* create static_transform_publisher for each virtual joint type * another $(dirname) augmenting #2748 * formatting
Available since lunar. This simplifies the descriptions in moveit_resources
quite a bit because their package name does not match the include path
and we have to adapt the names everywhere after edits.
Note that two candidates for this replacement still remain -
they define the file path to the rviz config in an arg value.
Due to a bug these two can not be replaced at this moment.
@gavanderhoorn Could you please review this patch?