cherry picking from Kinetic#1160
Merged
rhaschke merged 2 commits intomoveit:melodic-develfrom Oct 26, 2018
Merged
Conversation
11e9d1a to
2e6f28f
Compare
| #include <moveit/kinematic_constraints/utils.h> | ||
| #include <moveit/profiler/profiler.h> | ||
| #include <moveit/utils/lexical_casts.h> | ||
| #include <eigen_conversions/eigen_msg.h> |
Contributor
There was a problem hiding this comment.
This extra include introduces a regression in melodic-devel:
http://build.ros.org/view/Mbin_uB64/job/Mbin_uB64__moveit_planners_ompl__ubuntu_bionic_amd64__binary/17/console
We removed the eigen_conversions tf1 dependency in #830
Contributor
Author
There was a problem hiding this comment.
Argh! Can you device a fix?
Contributor
There was a problem hiding this comment.
Yep! This is a spurious include. It's as simple as removing that line.
Contributor
Author
There was a problem hiding this comment.
Just have seen #1174 fixes the issue (hopefully).
11 tasks
IanTheEngineer
added a commit
that referenced
this pull request
Oct 30, 2018
moveit_planners_ompl had a a Melodic buildfarm failure this morning: http://build.ros.org/view/Mbin_uB64/job/Mbin_uB64__moveit_planners_ompl__ubuntu_bionic_amd64__binary/17/ This commit removes an unneeded include from #1160
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please use rebase-commit to merge!