Fix values in PlanningFrame not beeing stored#1135
Merged
rhaschke merged 4 commits intomoveit:kinetic-develfrom Oct 26, 2018
Merged
Fix values in PlanningFrame not beeing stored#1135rhaschke merged 4 commits intomoveit:kinetic-develfrom
rhaschke merged 4 commits intomoveit:kinetic-develfrom
Conversation
davetcoleman
approved these changes
Oct 25, 2018
rhaschke
approved these changes
Oct 25, 2018
rhaschke
requested changes
Oct 25, 2018
Contributor
rhaschke
left a comment
There was a problem hiding this comment.
I missed that there are some extra semicolons! Thanks to clang.
moveit_ros/visualization/motion_planning_rviz_plugin/src/motion_planning_display.cpp
Outdated
Show resolved
Hide resolved
moveit_ros/visualization/motion_planning_rviz_plugin/src/motion_planning_display.cpp
Outdated
Show resolved
Hide resolved
Co-Authored-By: agutenkunst <a.gutenkunst@pilz.de>
Co-Authored-By: agutenkunst <a.gutenkunst@pilz.de>
rhaschke
approved these changes
Oct 26, 2018
rhaschke
pushed a commit
to ubi-agni/moveit
that referenced
this pull request
Oct 26, 2018
rhaschke
pushed a commit
that referenced
this pull request
Oct 26, 2018
JafarAbdi
pushed a commit
to JafarAbdi/moveit
that referenced
this pull request
Mar 24, 2022
replace new operator with make_shared
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Multiple values from the PlanningFrame (see Image) are not stored in the config.
Fixed by this PR. Still missing is the valueChanged notification to rviz. Will open seperate PR.