Porting geometric_shapes to ROS2#110
Closed
anasarrak wants to merge 21 commits intomoveit:melodic-develfrom
Closed
Porting geometric_shapes to ROS2#110anasarrak wants to merge 21 commits intomoveit:melodic-develfrom
anasarrak wants to merge 21 commits intomoveit:melodic-develfrom
Conversation
Replaced by shape_msgs::msg::SolidPrimitive
Requires further work
Change bodies Eigen::Issometry calls to Eigen::Affine3d
Return back to Isometry3d
Fix cmakelists to compile against other executables and fixing tests
reformat it slightly as well. This commit allows linking in OS X but requires console_bridge to be installed from sources. Note that console_bridge_vendor is a shim over console_bridge and still requires the installation of the later through its sources.
Fix packages.xml
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can we create a ros2 branch for that?