Port to ROS 2 dashing (new branch)#118
Closed
henningkayser wants to merge 4 commits intomoveit:dashing-develfrom
Closed
Port to ROS 2 dashing (new branch)#118henningkayser wants to merge 4 commits intomoveit:dashing-develfrom
henningkayser wants to merge 4 commits intomoveit:dashing-develfrom
Conversation
rhaschke
requested changes
Nov 15, 2019
Contributor
rhaschke
left a comment
There was a problem hiding this comment.
Hi Henning, it would be great if you could cleanup the commit history somewhat and have individual commits for:
- msg related changes
- cmake/catkin/ament related changes
- real code changes (probably none)
Contributor
6993192 to
db38028
Compare
f5eb936 to
eae9fb0
Compare
Member
Author
@rhaschke I squashed all commits into a more readable history and applied your requested changes. Travis fails because of warnings in octomap and because there is no CMAKE_BUILD_TYPE defined. For the latter we need to pass the parameter to |
This was referenced Nov 15, 2019
Merged
Contributor
|
Rebased onto latest HEAD in #122. |
This was referenced Nov 17, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fixup of the previous ROS 2 migration attempts and synced with melodic-devel.
I created the 'new' dashing-devel based on melodic devel, so this PR only lists the migration steps.
When this gets merged, I suggest we remove crystal-devel and close the PRs #96 and #110