Skip to content
This repository was archived by the owner on Aug 8, 2024. It is now read-only.

Conversation

@radical
Copy link
Member

@radical radical commented Aug 7, 2019

This includes:

  • Update to upstream vs16.3 branch
  • SDK update to track dotnet release/3.0.100-preview8
  • Roslyn updated to 3.3.0-beta2-19381-14

rainersigwald and others added 30 commits February 15, 2019 14:19
When UTF-8 is the system default codepage, the encoding we get is
`Encoding.UTF8`, which uses a BOM. Unfortunately, `cmd.exe` emits an
error when trying to execute a file that starts with a BOM, so all Exec
tasks on an OS with that configuration are broken.

Instead, if the default encoding is a UTF-8 variant with a BOM, force it
to use UTF-8 with no BOM.
This is convoluted because MSBuildTaskHost isn't built all the time:
since it targets .NET 3.5, it can only be built from full framework
MSBuild. So introduce a new define to conditionalize the test.
`CancelledBuildInTaskHostWithDelay20` was running the MSBuild 3.5
version of the Exec task in a TaskHost, but the TaskHost in question
used the 4.0 runtime, so it ran in a copy of MSBuild.exe.

This didn't exercise the more-interesting pathway of running the
legacy task in the legacy-compat environment in MSBuildTaskHost.exe.
Preserve edges from graph construction in order to retrieve ProjectReferenceItem.Targets at target computation time.
Co-Authored-By: Rainer Sigwald <raines@microsoft.com>
This is a very slight optimization, as string.equals checks that lengths are equal before comparing characters.
Another very slight optimization. Checking this first eliminates a reasonable number of allocations done by GetDirectoryName. Can be further optimized.
Also fixed issue with IsDrivePatternWithSlash accessing an out of bounds index. Forgot parantheses (whoops)
Can be improved by further investigating edge cases that Path.GetDirectoryName returns null in.
Livar and others added 15 commits July 23, 2019 09:52
…32-4464-a768-93d8d2950520

[master] Update dependencies from dotnet/arcade
Fixes dotnet#4547 by respecting the Implementation metadata only when it's a .dll. The <16.2.0 behavior would only find a .dll, and the comment on ImplementationAssembly expects it to always be a .dll, so I think this is reasonable.
* Update dependencies from https://github.com/dotnet/arcade build 20190723.6

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19373.6

* Update dependencies from https://github.com/dotnet/arcade build 20190724.2

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19374.2

* Update dependencies from https://github.com/dotnet/arcade build 20190725.2

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19375.2
…otnet#4544)

This test was disabled long ago but appears to be fine now, presumably due to CoreFX updates.

Fixes dotnet#301.
WinRT: Accept Implementation metadata only when it's a DLL
…726.18

- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19376.18
…a3-4e7a-9a9b-c92457bc2288

[master] Update dependencies from dotnet/arcade
This had to be cobbled together manually, as the build details changed
upstream.

Branch:     `dotnet/toolset` - `release/3.0.100-preview8`
HEAD:       9c8c1c8

Microsoft.NET.Sdk:                          3.0.100-preview8.19406.1
Microsoft.NET.Build.Extensions:             3.0.100-preview8.19406.1

Microsoft.NET.Sdk.Web:                      3.0.100-preview8.19406.4
Microsoft.NET.Sdk.Publish:                  3.0.100-preview8.19406.4
Microsoft.NET.Sdk.Web.ProjectSystem:        3.0.100-preview8.19406.4

Microsoft.NET.Sdk.Razor:                    3.0.0-preview8.19405.5

ILLink.Tasks:                               0.1.6-prerelease.19379.2

NuGet.Build.Tasks*:                         5.3.0-preview.2.6136

libhostfxr.dylib:                           3.0.100-preview8-013422
	- copied from `dotnet`, installed with `./eng/common/dotnet-install.sh -v 3.0.100-preview8-013422`

Microsoft.DotNet.MSBuildSdkResolver:        3.0.100-preview8.19406.4
	- version from `core-sdk` repo's HEAD
		https://github.com/dotnet/core-sdk/blob/8bf06ffc8d99abcc7c8a923e90b35d122887976d/eng/Versions.props#L36
	- on suggestion from Livar Cunha .

Versions from https://github.com/dotnet/toolset/blob/9c8c1c85d181cde1d7c43180c4072ce4c2f54adb/eng/Versions.props
@radical
Copy link
Member Author

radical commented Aug 7, 2019

Also, updated to track upstream vs16.3 branch.

@radical radical merged commit 35820d0 into mono:mono-2019-06 Aug 7, 2019
@radical radical deleted the update-sdks-roslyn-2019-06 branch August 7, 2019 19:26
akoeplinger pushed a commit to mono/mono that referenced this pull request Aug 8, 2019
Prompted by mono/msbuild#123 :

This includes:

Update to upstream vs16.3 branch
SDK update to track dotnet release/3.0.100-preview8
Roslyn updated to 3.3.0-beta2-19381-14

* Work around remoting1.exe test issue with new Roslyn
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.