Audit for copy intrinsic#1199
Merged
adpaco-aws merged 3 commits intomodel-checking:mainfrom May 16, 2022
Merged
Conversation
2369fe3 to
7a968ec
Compare
celinval
reviewed
May 13, 2022
Contributor
celinval
left a comment
There was a problem hiding this comment.
Just one question about whether we should check if length is zero before adding the checks.
| /// size_of::<T>()` bytes (done by calls to `memmove`) | ||
| /// In addition, we check that computing `count` in bytes (i.e., the third | ||
| /// argument for the `memmove` call) would not overflow. | ||
| fn codegen_copy_intrinsic( |
Contributor
There was a problem hiding this comment.
Functions are so much better!
|
|
||
| // Generate alignment checks for both pointers | ||
| let src_align = self.is_ptr_aligned(farg_types[0], src.clone()); | ||
| let src_align_check = self.codegen_assert( |
Contributor
There was a problem hiding this comment.
Are these checks relevant if length is zero?
Contributor
Author
There was a problem hiding this comment.
Yes, please see the last sentence in "Safety" here: https://doc.rust-lang.org/std/intrinsics/fn.copy.html
Note that even if the effectively copied size
(count * size_of::<T>())is 0, the pointers must be non-null and properly aligned.
celinval
approved these changes
May 13, 2022
Contributor
celinval
left a comment
There was a problem hiding this comment.
Great test coverage! Thanks
4 tasks
77 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Completes the audit for the
copyintrinsic, which was disabled in #1081:srcanddst.Initially, the changes in this PR were for both
copyandcopy_nonoverlapping, but as it has been noted in #1176 thecopy_nonoverlappingcase is handled somewhere else.Resolved issues:
Creates #1198
Part of #1163
Call-outs:
Testing:
How is this change tested? Existing regression and 7 new/restored tests.
Is this a refactor change? No.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.