Merged
Conversation
tedinski
approved these changes
May 9, 2022
Contributor
tedinski
left a comment
There was a problem hiding this comment.
Was this just legacy from before we had intrinsic handling code?
adpaco-aws
previously requested changes
May 10, 2022
Contributor
adpaco-aws
left a comment
There was a problem hiding this comment.
I thought that removing this hook would still require you to add implementations for write and write_unaligned as intrinsics, but this does not seem to be the case. So the code for handling these "writes" must be somewhere else.
Can you please find out where the code handling these "writes" is? The regular version should have an alignment check as in codegen_volatile_store.
Contributor
Author
|
Blocked on diffblue/cbmc#6856 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
The PtrWrite hook is no longer necessary given that we support the underlying intrinsics.
Resolved issues:
Resolves #1173
Call-outs:
Removing the
PtrReadhook makes the regression timeout. Only removing PtrWrite for now. #1175Testing:
How is this change tested? Existing tests
Is this a refactor change? No
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.