Audit copy_nonoverlapping intrinsic#1201
Merged
adpaco-aws merged 7 commits intomodel-checking:mainfrom May 20, 2022
Merged
Conversation
1c61e9d to
03d7f54
Compare
celinval
reviewed
May 16, 2022
celinval
suggested changes
May 17, 2022
Contributor
celinval
left a comment
There was a problem hiding this comment.
Thanks for reducing the duplicated code. I just have a few comments besides my previous comment that I published too soon.
| @@ -0,0 +1 @@ | |||
| memcpy src/dst overlap No newline at end of file | |||
Contributor
There was a problem hiding this comment.
Is this a CBMC message? I was wondering if we change it to say copy_nonoverlap here. Do we use memcpy anywhere else?
Contributor
Author
There was a problem hiding this comment.
Yes, this is a CBMC message so there's not much we can do. We use memcpy in our __rust_realloc C implementation but we don't generate calls to memcpy anywhere else.
tests/expected/intrinsics/copy-nonoverlapping/copy-unaligned-dst/expected
Outdated
Show resolved
Hide resolved
77 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Completes the audit for the
copy_nonoverlappingintrinsic by reusing the work done on thecopyintrinsic (see #1199):srcanddst.Resolved issues:
Resolves #1198
Part of #1163
Testing:
How is this change tested? Existing regression and new tests
Is this a refactor change? No.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.