Disable unaudited intrinsics#1081
Merged
adpaco-aws merged 10 commits intomodel-checking:mainfrom Apr 21, 2022
Merged
Conversation
celinval
suggested changes
Apr 20, 2022
Contributor
celinval
left a comment
There was a problem hiding this comment.
Instead of removing, can you wrap it up inside an unstable macro that just ignores the code? It will make it much easier to revert back. We can even put it under --enable-unstable later on.
celinval
approved these changes
Apr 21, 2022
Closed
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 26, 2022
* Disable unaudited intrinsics * Updated intrinsics table * Use `unstable_codegen` macro * Edit link * Disable `copy` tests too
tedinski
pushed a commit
that referenced
this pull request
Apr 27, 2022
* Disable unaudited intrinsics * Updated intrinsics table * Use `unstable_codegen` macro * Edit link * Disable `copy` tests too
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Disables a considerable amount of unaudited intrinsics and updates the documentation to reflect the status. Converts 3 tests to "fixme" because they use or depend on intrinsics that are now disabled.
Resolved issues:
Part of #727
Call-outs:
Testing:
How is this change tested? Converts 3 tests to "fixme".
Is this a refactor change? No.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.