Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: moby/spdystream
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.2.0
Choose a base ref
...
head repository: moby/spdystream
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.3.0
Choose a head ref
  • 8 commits
  • 5 files changed
  • 5 contributors

Commits on Dec 19, 2022

  1. gha: update go versions

    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    thaJeztah committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    9e99574 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #90 from thaJeztah/update_go_versions

    gha: update go versions
    thaJeztah authored Dec 19, 2022
    Configuration menu
    Copy the full SHA
    57d1ca2 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2023

  1. Fix Ping data-race

    While testing some code under `-race` flag, the race detector flagged a
    data race on `spdystream.Ping` code path.
    
    ```
    ==================
    WARNING: DATA RACE
    Read at 0x00c012a966a8 by goroutine 483923:
      github.com/moby/spdystream.(*Connection).handlePingFrame()
          /go/pkg/mod/github.com/moby/spdystream@v0.2.0/connection.go:615 +0x3e
      github.com/moby/spdystream.(*Connection).frameHandler()
          /go/pkg/mod/github.com/moby/spdystream@v0.2.0/connection.go:432 +0x144
      github.com/moby/spdystream.(*Connection).Serve.func2()
          /go/pkg/mod/github.com/moby/spdystream@v0.2.0/connection.go:331 +0xa6
      github.com/moby/spdystream.(*Connection).Serve.func4()
          /go/pkg/mod/github.com/moby/spdystream@v0.2.0/connection.go:332 +0x47
    
    Previous write at 0x00c012a966a8 by goroutine 483918:
      github.com/moby/spdystream.(*Connection).Ping()
          /go/pkg/mod/github.com/moby/spdystream@v0.2.0/connection.go:281 +0x117
      github.com/moby/spdystream.(*Connection).Ping-fm()
          <autogenerated>:1 +0x39
      k8s.io/apimachinery/pkg/util/httpstream/spdy.(*connection).sendPings()
          /go/pkg/mod/k8s.io/apimachinery@v0.26.3/pkg/util/httpstream/spdy/connection.go:197 +0x1b6
      k8s.io/apimachinery/pkg/util/httpstream/spdy.newConnection.func2()
          /go/pkg/mod/k8s.io/apimachinery@v0.26.3/pkg/util/httpstream/spdy/connection.go:96 +0x47
    
    Goroutine 483923 (running) created at:
      github.com/moby/spdystream.(*Connection).Serve()
          /go/pkg/mod/github.com/moby/spdystream@v0.2.0/connection.go:327 +0x9e
      k8s.io/apimachinery/pkg/util/httpstream/spdy.newConnection.func1()
          /go/pkg/mod/k8s.io/apimachinery@v0.26.3/pkg/util/httpstream/spdy/connection.go:94 +0x47
    
    Goroutine 483918 (running) created at:
      k8s.io/apimachinery/pkg/util/httpstream/spdy.newConnection()
          /go/pkg/mod/k8s.io/apimachinery@v0.26.3/pkg/util/httpstream/spdy/connection.go:96 +0x34d
      k8s.io/apimachinery/pkg/util/httpstream/spdy.NewClientConnectionWithPings()
          /go/pkg/mod/k8s.io/apimachinery@v0.26.3/pkg/util/httpstream/spdy/connection.go:57 +0x224
      k8s.io/apimachinery/pkg/util/httpstream/spdy.(*SpdyRoundTripper).NewConnection()
          /go/pkg/mod/k8s.io/apimachinery@v0.26.3/pkg/util/httpstream/spdy/roundtripper.go:357 +0x644
      k8s.io/client-go/transport/spdy.Negotiate()
          /go/pkg/mod/k8s.io/client-go@v0.26.3/transport/spdy/spdy.go:98 +0x42d
      k8s.io/client-go/tools/remotecommand.(*streamExecutor).newConnectionAndStream()
          /go/pkg/mod/k8s.io/client-go@v0.26.3/tools/remotecommand/remotecommand.go:125 +0x2d7
      k8s.io/client-go/tools/remotecommand.(*streamExecutor).StreamWithContext()
          /go/pkg/mod/k8s.io/client-go@v0.26.3/tools/remotecommand/remotecommand.go:157 +0xbc
    ==================
    ```
    
    This PR aims to fix the present data race.
    
    Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
    tigrato committed May 6, 2023
    Configuration menu
    Copy the full SHA
    3473c0b View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2024

  1. fixed data race

    Signed-off-by: niqote <niqote@yandex-team.ru>
    niqote committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    6cf8949 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2024

  1. Merge pull request #91 from tigrato/fix-ping-data-race

    Fix Ping data-race
    dmcgowan authored Jun 21, 2024
    Configuration menu
    Copy the full SHA
    06348fb View commit details
    Browse the repository at this point in the history
  2. Fix unit test races

    Signed-off-by: Derek McGowan <derek@mcgstyle.net> (github: dmcgowan)
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    dmcgowan authored and thaJeztah committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    31503b1 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #89 from thaJeztah/carry_48_fix_unit_test_race

    Fix unit test races (carry #48)
    dmcgowan authored Jun 21, 2024
    Configuration menu
    Copy the full SHA
    478d001 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #96 from code-qote/fix-stream-is-finished-data-race

    Fixed data race in Stream.IsFInished()
    dmcgowan authored Jun 21, 2024
    Configuration menu
    Copy the full SHA
    0c1fc43 View commit details
    Browse the repository at this point in the history
Loading