Skip to content

gha: update go versions#90

Merged
thaJeztah merged 1 commit into
moby:masterfrom
thaJeztah:update_go_versions
Dec 19, 2022
Merged

gha: update go versions#90
thaJeztah merged 1 commit into
moby:masterfrom
thaJeztah:update_go_versions

Conversation

@thaJeztah

@thaJeztah thaJeztah commented Dec 19, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Looks like CI was no longer working, because ltag now required a newer version of go;

pushd $(mktemp -d) \
  && go get -u github.com/kunalkushwaha/ltag \
  && popd \
  && ./scripts/validate/fileheader
  shell: /usr/bin/bash -e {0}
  env:
    GOROOT: /opt/hostedtoolcache/go/1.13.15/x64
/tmp/tmp.wrQsimdF1t ~/work/spdystream/spdystream
# github.com/kunalkushwaha/ltag
Error: /home/runner/go/src/github.com/kunalkushwaha/ltag/bash.go:25:15: undefined: os.ReadFile
Error: /home/runner/go/src/github.com/kunalkushwaha/ltag/dockerfile.go:23:15: undefined: os.ReadFile
Error: /home/runner/go/src/github.com/kunalkushwaha/ltag/golang.go:23:15: undefined: os.ReadFile
Error: /home/runner/go/src/github.com/kunalkushwaha/ltag/makefile.go:15:15: undefined: os.ReadFile
Error: Process completed with exit code 2.

@thaJeztah
gha: update go versions
9e99574 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah

thaJeztah commented Dec 19, 2022

Copy link
Copy Markdown
Member Author

@dims PTAL

@thaJeztah thaJeztah mentioned this pull request Dec 19, 2022
Merged
dims
dims approved these changes Dec 19, 2022
View reviewed changes

@dims dims left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah

thaJeztah commented Dec 19, 2022

Copy link
Copy Markdown
Member Author

Thx! Let me get this one in, and rebase the other one 👍

@thaJeztah thaJeztah merged commit 57d1ca2 into moby:master Dec 19, 2022
@thaJeztah thaJeztah deleted the update_go_versions branch December 19, 2022 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dims dims dims approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thaJeztah @dims