Fix unit test races (carry #48)#89
Merged
Merged
Conversation
Member
Author
|
CI failure is unrelated; will be fixed by #90 |
Member
Author
|
@dims PTAL 🤗 |
Collaborator
|
hmm, 90 needs one more approval before we can land that and make this go green here |
73570da to
04c4b9a
Compare
Member
Author
I, erm, went slightly ahead and got that one in to fix CI 😅 😇 @dmcgowan ptal |
Member
Author
|
FWIW; I just noticed that #86 also has a fix for this, so we could choose to take that one as well (I guess either approach would work) |
dmcgowan
approved these changes
Dec 20, 2022
Member
|
Either is fine, #86 is a bit bigger and think it needs some validation |
|
/lgtm I'm going to close #86 since it should no longer needed |
Signed-off-by: Derek McGowan <derek@mcgstyle.net> (github: dmcgowan) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
04c4b9a to
31503b1
Compare
Member
Author
|
@dmcgowan I saw you merged another PR; I rebased this one again to get a fresh run of CI 👍 |
dmcgowan
approved these changes
Jun 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
carries: #48
closes #48